Repository navigation
Household picker: common inputs first, topics, one entity per search - #1319
Merged
Merged
Conversation
The variable search's categories were one line of pill buttons that scrolled sideways. They are now a column beside the list, every category in view with its count; on a phone, one category choice above the list. In the report's household form, the open search takes the add link's place on a line of its own under the fields. Its width cap alone kept it in their row, where it had no label and sat above their boxes. On a phone the fields' block no longer grows wider than the screen when the list opens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
In a narrow person card the list was as wide as the search box, so the category column left no room for the variables. The grouped list now opens as a panel over the page, up to 40rem wide and kept on screen, at a fixed height so it does not move when a category changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ount Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The floating list still took its size from where it opened. The grouped search is now a dialog of a standard size (up to 56rem wide, 40rem tall, kept inside the screen), centered over the page: its title names who the variable is for, the search sits in its header, and the category column and the list fill the rest. Picking a variable adds it and closes the dialog; Esc, the close button or a click outside closes it too. The plain list (v2) is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PavelMakarchuk
changed the title
…ts left out - searchByEntity (opt-in): a person's search lists person inputs only; the household's lists every group entity's (household, tax unit, SPM unit, family, marital unit, one of each in the builder). With every row the search's own entity, the per-row Person/Household badge goes. - A chosen category with parts reads part by part: Income splits into wages and work, self-employment and business, investments, retirement and other income, each in label order. - v3 leaves out inputs that do not describe a household: SPM-unit survey totals, CBO incidence inputs, reported amounts and deprecated inputs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed below Each row's description made the list a wall of text. Rows are now one line, the variable's name. The row under the pointer, or the one the arrow keys reach, is described once, in a footer under the list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The variable dialog opens on what most households need: up to nine common inputs as tiles with short names and icons (rent, self-employment income, tips, unemployment, Social Security, pension, interest, medical expenses; child care, utilities, mortgage and assets for the household), then the reform's related inputs. Topics, each with an icon, sit in a column beside it (tiles on a phone). A topic lists its inputs by name, one line each, part by part; a search lists its matches. The input under the pointer is described once, below the list. The dialog is its own component, VariablePickerDialog, which the dropdown opens when given groups; the inline list (v2) is unchanged. A scoped search also leaves out inputs the person or household already has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PavelMakarchuk
changed the title
…t view is Featured A stacked field's label wrapped to two lines when the model's label was long, pushing its box below its neighbours'. Stacked labels now keep to one line (the full name on hover), and the builder's fields take the picker's short names (Child care expenses, not Spm unit pre subsidy child care expenses). The picker's first view is called Featured. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…something - Featured lists its inputs by name, in the same rows as a topic, with no tiles or icons. - Related to this reform: the trace stops 4 steps upstream (past that, every input reaches a tax credit through AGI), leaves out state programs' own inputs and filing flags, ranks common household inputs first, and is cut to size after the person/household split. One lone related input shows no list. - A reform the report finds changes nothing in its year suggests no inputs (report 4571: the CTC's 17-and-over bracket, which no child qualifies for). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e each takes
The model documents only 2 of the 17 featured inputs. Each featured
input now carries a one-line description of what to enter, shown in
the picker's footer and as the field label's hover text; the model's
own documentation wins where it has one. The footer also says what
kind of value an input takes, from its unit, type and period
("Dollars per year", "Yes or no", "Number"), for every input.
Variable metadata now carries its definition period.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
VariablePickerDialog): in the v3 household tab, "Add variable" opens a centered dialog of a standard size. It opens on Featured: up to nine common inputs listed by name (rent, self-employment income, tips, unemployment, Social Security, pension, interest, medical expenses; for the household: child care, utilities, mortgage, assets, vehicles). Under them, the inputs related to the reform.*_reportedamounts and deprecated inputs.v2 pages: the dropdown opens the picker only where
groupOfis passed; only the v3 household tab passes it. The inline list is unchanged.Tests
VariablePickerDialog.test.tsx: tiles, topics with parts, search, the description footer, related inputs.HouseholdBuilderForm.test.tsx: each search lists its own entity's inputs.householdVariableGroups.test.ts: income parts, inputs left out.🤖 Generated with Claude Code