Repository navigation
Theme server: stopping it while its first renderer starts leaves noth… - #367
Merged
Merged
Conversation
…ing behind The managed server starts its first renderer in the background (warm()). Stopped before that finished (B soon after opening the Theme Editor, or a slow CI runner: test_managed_server failed on 3.12 and 3.13 on main), RenderPool.stop() didn't know about the zygote yet. serve.py removed its work folder and exited, and the zygote, still starting, made the folder again with mkdir(parents=True), leaving pm-theme-server-* in /tmp (seen on muOS too). - RenderPool.stop() marks the pool as stopping (nothing starts after it) and waits up to 10 s for a start under way, then stops it with the rest. PortMaster kills the server after 15 s. - worker.py makes its folders one level at a time, never parents=True: one starting after the server's folder is gone fails instead of making it. Reproduced with every core busy: the old code left the folder behind when stopped straight after starting; with this, 18 of 18 runs pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxABmR1rUUgi4iicVLZchY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing behind
The managed server starts its first renderer in the background (warm()). Stopped before that finished (B soon after opening the Theme Editor, or a slow CI runner: test_managed_server failed on 3.12 and 3.13 on main), RenderPool.stop() didn't know about the zygote yet. serve.py removed its work folder and exited, and the zygote, still starting, made the folder again with mkdir(parents=True), leaving pm-theme-server-* in /tmp (seen on muOS too).
Reproduced with every core busy: the old code left the folder behind when stopped straight after starting; with this, 18 of 18 runs pass.