Repository navigation
fix: Flush events on process exit - #224
Merged
Merged
Conversation
|
cc @fuziontech ;P |
markovejnovic
changed the title
fuziontech
approved these changes
Oct 7, 2026
fuziontech
left a comment
fuziontech
left a comment
Member
There was a problem hiding this comment.
Nice catch! Thanks for the PR and fix!!
Contributor
Author
|
ugh okay commit signing. i need to set up my gpg, give me a second |
dustinbyrne
approved these changes
Oct 8, 2026
dustinbyrne
left a comment
dustinbyrne
left a comment
Contributor
There was a problem hiding this comment.
ugh okay commit signing. i need to set up my gpg, give me a second
😅 thank you! do you mind adding a changeset so this triggers an official release once we merge? otherwise the change looks good!
Contributor
Author
|
Sounds good, thank you @dustinbyrne =), finally got my gpg configured, on both of those now =) |
markovejnovic
force-pushed
the
fix/flush-on-process-exit
branch
from
October 8, 2026 01:06
07c4ca0 to
ee66007
Compare
Contributor
Author
|
done, thanks @dustinbyrne |
Contributor
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Fixes #223.
💚 How did you test it?
Ran
mix test test/posthog/sender_test.exson the first commit (which correctly tied the supervision to the test harness), which failed. Then ranmix test test/posthog/sender_test.exson the second commit which succeeded. Proof attached as screenshots.Thank you!
📝 Checklist