Repository navigation
fix: repair regressions found after the 2026-09-13 upstream sync - #12
Merged
Merged
Conversation
_session_mcp_servers returned [] for every backend outside ACP_BACKENDS_SESSION_MCP_ARRAY. kiro-cli is outside it, and the session array is the only channel its pooled broker stubs have, so since the 2026-09-04 sync (a0ef05b) every non-private kiro-cli session ran its MCP servers direct instead of through the broker. kiro-cli now receives the deduplicated pooled stubs; private-memory sessions still get none (no overlay). The roster is built in one worker-thread hop, the same single hop the pooled read always took. Tests: the private-routing test models the fork's spawn-time withhold verdict, and the kirodotdev#3528 builder ratchet accepts the consolidated roster only while every branch of it still appends the pooled stubs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The watcher sweep still awaited _discover_drop_folder and _discover_project_docs, which no longer exist, so every sweep raised AttributeError. Upstream removed both calls with the methods. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
b617acd reloaded subagent_max_per_parent{,_by_agent} in apply_limits, but LIVE_CONFIG_PATHS never watches them, so a saved change applied only when an unrelated live setting happened to change. The fork's design (1aa1ee8) reads them at construction; the schema now says restart=True, which the dashboard's schema-driven restart hint surfaces, and the half-live reload is removed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
- codex permission census: the fork's Claude-only autonomous reader is a third, reject-only site (0b3f3c1); Codex paths must still run the refusal. - directive and members DM harnesses: trusted MCP identity (ce19f2d) and the fork's async set_claude_autonomous_turn_handler. - memv2 prompt audit: same async handler on the inner client mock. - consolidate agent: identity and key now live in history_consolidation, and the resume decision in _get_or_create_impl. - upload pickers: quote/whitespace-agnostic, the fork formats ChatInput with Prettier. - work ledger kinds: read from kiro_crew.work_acceptance, the product evaluator the conductor adapter reaches. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
GPT 5.6 Review —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11. A wider run of the ~66k tests the sync changed (merged tree vs upstream b4ed39b vs deployed b4c62de, clean environment) found 90 merge-only failures; 74 reproduced on rerun. All 74 now pass.
Product fixes
acp/client.py)._session_mcp_serversreturned[]for backends outsideACP_BACKENDS_SESSION_MCP_ARRAY, so since the 2026-09-04 sync every non-private kiro-cli session ran its MCP servers direct instead of through the broker. Private-memory sessions still receive none. No private-memory tool was ever exposed.knowledge/watcher.py). It awaited_discover_drop_folder/_discover_project_docs, which upstream removed, so every sweep raised. The live gateway logsSource watcher scan failed … AttributeErrorevery 5 minutes since the 2026-09-10 deploy.config/sections.py,subagent.py). Reverts the half-live reload from b617acd:LIVE_CONFIG_PATHSnever watched these fields.Test adaptations
Upstream tests updated for fork shapes (Claude-only autonomous permission site, trusted MCP identity, async autonomous-turn handler, consolidation module layout, Prettier-formatted ChatInput, product acceptance evaluator) plus the kirodotdev#3528 pooled-builder ratchet.
Remaining failures in the touched files
11 in
test_acp_client.py/test_acp_runtime.py; all fail on deployed b4c62de too and pass upstream (fork test debt).Not deployed.
🤖 Generated with Claude Code