Skip to content

fix: repair regressions found after the 2026-09-13 upstream sync - #12

Merged
Premshay merged 4 commits into
mainfrom
fix/post-sync-20260913
Sep 14, 2026
Merged

Premshay merged 4 commits into
mainfrom
fix/post-sync-20260913

Conversation

@Premshay

Copy link
Copy Markdown
Owner

Follow-up to #11. A wider run of the ~66k tests the sync changed (merged tree vs upstream b4ed39b vs deployed b4c62de, clean environment) found 90 merge-only failures; 74 reproduced on rerun. All 74 now pass.

Product fixes

  • kiro-cli sessions get pooled MCP broker stubs again (acp/client.py). _session_mcp_servers returned [] for backends outside ACP_BACKENDS_SESSION_MCP_ARRAY, so since the 2026-09-04 sync every non-private kiro-cli session ran its MCP servers direct instead of through the broker. Private-memory sessions still receive none. No private-memory tool was ever exposed.
  • Knowledge watcher sweep works again (knowledge/watcher.py). It awaited _discover_drop_folder / _discover_project_docs, which upstream removed, so every sweep raised. The live gateway logs Source watcher scan failed … AttributeError every 5 minutes since the 2026-09-10 deploy.
  • Per-parent subagent caps are restart-only (config/sections.py, subagent.py). Reverts the half-live reload from b617acd: LIVE_CONFIG_PATHS never watched these fields.

Test adaptations

Upstream tests updated for fork shapes (Claude-only autonomous permission site, trusted MCP identity, async autonomous-turn handler, consolidation module layout, Prettier-formatted ChatInput, product acceptance evaluator) plus the kirodotdev#3528 pooled-builder ratchet.

Remaining failures in the touched files

11 in test_acp_client.py / test_acp_runtime.py; all fail on deployed b4c62de too and pass upstream (fork test debt).

Not deployed.

🤖 Generated with Claude Code

Premshay and others added 4 commits September 14, 2026 12:12
_session_mcp_servers returned [] for every backend outside
ACP_BACKENDS_SESSION_MCP_ARRAY. kiro-cli is outside it, and the session array
is the only channel its pooled broker stubs have, so since the 2026-09-04 sync
(a0ef05b) every non-private kiro-cli session ran its MCP servers direct
instead of through the broker. kiro-cli now receives the deduplicated pooled
stubs; private-memory sessions still get none (no overlay). The roster is built
in one worker-thread hop, the same single hop the pooled read always took.

Tests: the private-routing test models the fork's spawn-time withhold verdict,
and the kirodotdev#3528 builder ratchet accepts the consolidated roster only while every
branch of it still appends the pooled stubs.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The watcher sweep still awaited _discover_drop_folder and
_discover_project_docs, which no longer exist, so every sweep raised
AttributeError. Upstream removed both calls with the methods.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
b617acd reloaded subagent_max_per_parent{,_by_agent} in apply_limits, but
LIVE_CONFIG_PATHS never watches them, so a saved change applied only when an
unrelated live setting happened to change. The fork's design (1aa1ee8) reads
them at construction; the schema now says restart=True, which the dashboard's
schema-driven restart hint surfaces, and the half-live reload is removed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
- codex permission census: the fork's Claude-only autonomous reader is a third,
  reject-only site (0b3f3c1); Codex paths must still run the refusal.
- directive and members DM harnesses: trusted MCP identity (ce19f2d) and the
  fork's async set_claude_autonomous_turn_handler.
- memv2 prompt audit: same async handler on the inner client mock.
- consolidate agent: identity and key now live in history_consolidation, and
  the resume decision in _get_or_create_impl.
- upload pickers: quote/whitespace-agnostic, the fork formats ChatInput with
  Prettier.
- work ledger kinds: read from kiro_crew.work_acceptance, the product
  evaluator the conductor adapter reaches.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 14, 2026
@Premshay
Premshay merged commit 06719c7 into main Sep 14, 2026
27 of 37 checks passed
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Sep 14, 2026
@github-actions

Copy link
Copy Markdown

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for e17dc935faa6f71b0a81e5a77566a43d5d05adf7; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt e17dc935faa6f71b0a81e5a77566a43d5d05adf7: <one-sentence reason>

@Premshay
Premshay deleted the fix/post-sync-20260913 branch November 13, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant