Repository navigation
fix(dashboard): stop counting day-old failed workflows as blocked - #41
Merged
Merged
Conversation
A failed workflow run counted as Blocked in the Command Center dock for as long as its record existed, and runs are kept on disk, so the tile kept counting failures from weeks earlier. The run snapshot now reports ended_at (the terminal event's ts), and the panel counts a failed run as blocked for 24 hours after it ended, then as stopped. A run with no ended_at keeps the previous behaviour. Closes kirodotdev#18290 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
GPT 6.1 Review —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork copy of upstream PR #18291 (issue #18290), cherry-picked onto fork main.
ended_at.Testing
test_workflows_registry.py: 13 passed.commandCenterModel.test.ts: 52 passed.🤖 Generated with Claude Code