Skip to content

fix(chat): release the inert overlays when a finger touches the page - #65

Merged
Premshay merged 1 commit into
mainfrom
fix/inert-release-on-touch
Oct 9, 2026
Merged

Premshay merged 1 commit into
mainfrom
fix/inert-release-on-touch

Conversation

@Premshay

@Premshay Premshay commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Ports the upstream UX-review fix from kirodotdev/KiroCrew#18491: while a selection was held, the first tap on the composer or the header was swallowed. A capture-phase touchstart now clears inert. Handle drags fire no touch events, so they still keep the overlays inert. The test fixtures also move off innerHTML to match the upstream rule.

Tests: inert hook + overlay contract 9/9; tsc clean.

🤖 Generated with Claude Code

UX review on the upstream PR: while a transcript selection was held the
header, composer dock and phone top bar stayed inert, so the first tap
on any of them fell through to the transcript and only cleared the
selection. Android's selection handles dispatch no touch events, so a
touchstart is the reader reaching for something: release the overlays
in the capture phase and let the next handle move re-apply them.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Premshay
Premshay merged commit ebcb807 into main Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

GPT 6.1 Review — ⚠️ review incomplete

GPT 6.1 did not produce a complete verdict for 8e0eadfe13c9cb123fea8f7ca53e06c787b04ece; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 6.1 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 8e0eadfe13c9cb123fea8f7ca53e06c787b04ece: <one-sentence reason>

@Premshay
Premshay deleted the fix/inert-release-on-touch branch November 13, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant