Repository navigation
fix(chat): release the inert overlays when a finger touches the page - #65
Merged
Merged
Conversation
UX review on the upstream PR: while a transcript selection was held the header, composer dock and phone top bar stayed inert, so the first tap on any of them fell through to the transcript and only cleared the selection. Android's selection handles dispatch no touch events, so a touchstart is the reader reaching for something: release the overlays in the capture phase and let the next handle move re-apply them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
GPT 6.1 Review —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the upstream UX-review fix from kirodotdev/KiroCrew#18491: while a selection was held, the first tap on the composer or the header was swallowed. A capture-phase
touchstartnow clearsinert. Handle drags fire no touch events, so they still keep the overlays inert. The test fixtures also move offinnerHTMLto match the upstream rule.Tests: inert hook + overlay contract 9/9; tsc clean.
🤖 Generated with Claude Code