Repository navigation
Conversation
This was referenced Nov 2, 2026
Progi1984
reviewed
Nov 3, 2026
Progi1984
left a comment
Member
There was a problem hiding this comment.
Have you tested on differents versions of PrestaShop (8.2, 9, 9.1, 9.2) ?
nicosomb
approved these changes
Nov 3, 2026
nicosomb
left a comment
Contributor
There was a problem hiding this comment.
Waiting for the load event works with and without the core fix (PrestaShop#43421), and the develop pages that keep clickAndWaitForURL on bulk links are Symfony grids. Progi1984's question is still open: only 9.2.x and develop have UI runs (PrestaShop#43422 / #43423), while 8.2 and 9.1 page objects change too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<a href="#" onclick="...sendBulkAction(...)">, so on the cores released so far the click first navigates to<current URL>#, then the form is posted.clickAndWaitForURLwaits for any URL change and resolves on that#, before the POST is even sent, so the page object reads the page of the previous step. This is howBO - Catalog price Rules : Bulk actions > should try to bulk delete cart rulesfailed twice in a row on 9.2.x (PrestaShop/PrestaShop#43420): it found the "Successful creation" alert of the previous step, then waited for a success alert on the POST page, which only has the error. This addsclickAndWaitForPageLoad, which waits for theloadevent of the new page (a same-document navigation fires none), and uses it for every legacy bulk action link: catalog price rules, cart rules, shop URLs, customer groups, stores (develop), countries, tax rules, quick access, tags (9.1), carriers and aliases (8.2).clickAndWaitForURLitself is left as it is, other callers may wait for an anchor navigation on purpose. Waiting for thesubmitBulkURL would not do either: on success the controller redirects to&conf=2, and that URL never shows.functional:BO:catalog:07-08should pass "BO - Catalog price Rules : Bulk actions" without retries.#navigation in the core, from 9.2.x on).ai conventions: 🟢
.ai/CONTEXT.md,.ai/Component/Playwright/CONTEXT.md(core); hygiene script clean,tscand ESLint clean on the touched filesVerification
bulkDeletePriceRulesfrom the built library, called the way the campaign does it: on the list right after "Successful creation" (&conf=3), with no row selected (expects "You must select at least one element to delete.") and with all rows selected (expects "The selection has been successfully deleted."), on a local 9.2.x shop:#)main#)mainThe library is needed even once the core fix is merged: it also runs against released cores that keep the
#. The9.1and8.2overrides are only used against those cores, which no core branch campaign runs; they get the same one-word change.