FOUR-32464: [Octane] Static issues - #8963
Open
pmPaulis wants to merge 120 commits into
Open
Conversation
FOUR-26188 implement service to read YAML config
FOUR-26192 Add job validation and new scheduling method `scheduleDateJob`
FOUR-26194 Implement a Schedulable Job to create the table in DB - Part 1
FOUR-31736 Implement Etag Cache for Tasks page
FOUR-32475 [Octane] CRITICAL Data Leaks Between Requests "AnonymousUs…
FOUR-32498 [Octane] MEDIUM — Accumulating State "addons"
…ocessMaker/processmaker into FOUR-32496
Description: Fix Octane state leak in ServerTimingMiddleware by reading min_package_time from config per request instead of a static property. Add tests for package timing threshold and config refresh between requests. Related tickets: https://processmaker.atlassian.net/browse/FOUR-32507
Description: Replace static $output and $taskTypes with per-instance state to prevent data leaking between requests under Octane. Add getOutput() and update UnblockRequest and ProcessRequestController callers. Related tickets: https://processmaker.atlassian.net/browse/FOUR-32504
FOUR-32496 Octane CRITICAL - Data Leaks Between Requests $queryTime
FOUR-32505 Octane MEDIUM — Accumulating State SettingObserver
Description: Reset request-scoped Manifest statics ($parents, $logger) in ResetRequestState after each Octane request. Keep $tableColumns as a schema cache. Related tickets: https://processmaker.atlassian.net/browse/FOUR-32502
FOUR-32507 [Octane] MEDIUM — Accumulating State "ServerTimingMiddleware"
…aker into feature/FOUR-32464
FOUR-32504 [Octane] MEDIUM — Accumulating State "RetryProcessRequest"
FOUR-32502 [Octane] MEDIUM — Accumulating State "Manifest"
FOUR-32501: [Octane] MEDIUM - Accumulating State ProcessMakerServiceProvider
FOUR-32497: [Octane] MEDIUM — Accumulating State "pmFunctions"
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 34069781 | Triggered | Generic Password | 6072037 | resources/views/auth/newLogin.blade.php | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
pmPaulis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Octane] Static Issues Accumulating State
Related Tickets & Packages
Code Review Checklist