fix(home): preserve profile catalog ordering on progressive mobile loads - #612
Open
Himanth-reddy wants to merge 1 commit into
Open
fix(home): preserve profile catalog ordering on progressive mobile loads#612Himanth-reddy wants to merge 1 commit into
Himanth-reddy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On mobile,
loadMobileHomeDataProgressivechecked_uiState.value.categories.isEmpty()to decide whether to lay out initial profile skeleton rows. Because preloaded Continue Watching items are inserted into_uiState.value.categoriesimmediately during startup,isEmpty()evaluated tofalse, bypassing skeleton initialization.Consequently, when in-memory Collection Rails (Services, Genres, Franchises) resolved in 0ms,
updateMobileCategoryRowappended them to the list before slower TMDB/MDBList network responses (Trending Movies/Shows) arrived. This caused Services/Genres/Franchises to jump above Trending rows and get written to the disk cache in that inverted order.Changes
orderCategoriesBySavedCatalogs()to ensure home rows strictly matchsavedCatalogsconfiguration (withcontinue_watchingprioritized at index 0).categories.isEmpty()with!hasRealBaseCategoriesinloadHomeData()andloadMobileHomeDataProgressive(), preserving any preloaded Continue Watching while laying out all other catalog skeletons.updateMobileCategoryRow()on mobile to enforcesavedCatalogsorder as asynchronous results arrive.HomeMobileCategoryOrderingTest.ktto verify that out-of-order category resolution preserves the configuredsavedCatalogsorder.Testing
./gradlew :app:testSideloadDebugUnitTest --tests "com.arflix.tv.ui.screens.home.*".