chore(deps): bundle the three open dependabot lockfile bumps - #1417
Merged
Conversation
ryanio
marked this pull request as draft
August 24, 2026 16:25
Bumps [immutable](https://github.com/immutable-js/immutable-js) from 4.1.0 to 4.3.9. - [Release notes](https://github.com/immutable-js/immutable-js/releases) - [Changelog](https://github.com/immutable-js/immutable-js/blob/main/CHANGELOG.md) - [Commits](immutable-js/immutable-js@v4.1.0...v4.3.9) --- updated-dependencies: - dependency-name: immutable dependency-version: 4.3.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.13 to 7.5.22. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.13...v7.5.22) --- updated-dependencies: - dependency-name: tar dependency-version: 7.5.22 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 2.0.1 to 2.1.4. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v2.0.1...v2.1.4) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 2.1.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
ryanio
marked this pull request as ready for review
August 25, 2026 16:07
ryanio
force-pushed
the
chore/dependency-bumps
branch
from
August 25, 2026 16:07
630cf90 to
a435244
Compare
BCLeFevre
approved these changes
Aug 25, 2026
jgriffos
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Three open dependabot PRs, all lockfile-only transitive bumps. They all edit the same
yarn.lock, so merging them one at a time forces the other two to rebase and burns a CI run each time. Bundling means one review and one CI run instead of three.Supersedes #1408, #1410 and #1412. Dependabot's commits are cherry-picked unchanged, so authorship and the advisory trail are preserved.
Solution
One file changes and it is
yarn.lock. Nopackage.json, no contract source, no submodule.None of the three packages appears in this repo's
dependenciesordevDependencies, so all are transitive.yarn.lockis not published to npm, so no consumer of the package is affected. The Solidity dependencies come from the git submodules in.gitmodulesrather than npm, so the contracts are untouched.The tar change is worth a second look because 6 to 7 is a major version. It needs no
package.jsonedit becauseresolutionsalready pins"tar": ">=4.4.18", which 7.x satisfies. tar 7 requires Node 18 or newer and CI runs 18.15.0, so the floor is met. This is the only item in the bundle with real breakage potential, and the Node jobs (Build Artifacts,Run Tests,Run Reference Tests,Run Linters) are what exercise it.Verification
Resolved versions after bundling:
All three cherry-picks applied without conflict, and the diff against
maintouches nothing butyarn.lock.The Forge jobs are red here, and not because of this change
mainstill carries the.gitmodulesbranch = <tag>pins that breakforge installbefore anything compiles, so all four Forge jobs fail on any branch cut from it. #1416 fixes that. Once it merges, this branch needs a rebase and the Forge jobs will go green.The jobs that actually validate a lockfile change are the Node ones, and those run independently of Foundry. Read them, not the Forge ones, when reviewing this.
Node-side result
Every non-Foundry check passed on this branch, which is the meaningful validation for a lockfile change and covers the tar 7 question:
The four Forge jobs fail at
forge installfor the reason described above, which is onmainand not in this diff.