Repository navigation
docs: Explain how canonical PIG traces store NUL characters - #1112
Open
promptless[bot] wants to merge 1 commit into
Open
promptless[bot] wants to merge 1 commit into
promptless[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Promptless/promptless#5409 fixes trace uploads that contain escaped NUL characters (U+0000). PostgreSQL JSONB rejects those characters, so the analyzer returned a 503 and the collector kept retrying the same range. The analyzer now normalizes NUL before it hashes and stores the canonical trace. As a result, a canonical object can differ from the native record it came from.
This adds a paragraph to Stored trace records in
governance/reference/trace-object-and-sources.mdx, so operators who inspect canonical objects know what to expect:\u0000. This keeps distinct keys distinct.No changelog entry: the fix makes uploads succeed as operators already expect.
Merge timing: the fix is in analyzer
0.3.2. The public stable catalog (pig-deploycatalog/stable.json) still lists only0.3.1, which doesn't include it. Merge this together with, or after,0.3.2is promoted, alongside #1039.Checklist