Repository navigation
Use one photo action in AI Tells Bingo - #1202
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
prithvi2206
marked this pull request as ready for review
October 25, 2026 18:29
prithvi2206
requested review from
adit-chandra,
frances720,
hawkeyexl and
mattlink
as code owners
October 25, 2026 18:29
2 tasks done
Contributor
Promptless documentation updates
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
AI Tells Bingo currently offers separate camera and upload buttons even though the upload action already opens the iPhone chooser with Photo Library, Take Photo, and Choose File. Replace both actions with one button labeled exactly Take or Upload Photo, including when replacing a photo.
Keep the existing upload input, accepted image types, selection handler, reset behavior, and
bingo_uploadtracking attribute. Remove the camera-only input and itscapture="environment"attribute. No photo processing, storage, or backend behavior changes.Update the browser regression suite to click the new button, verify one file input without forced capture, check mobile button layout, and cover cancellation with a draft or saved photo plus same-file retry.
Validation
npm run test:bingo: 10 passed.npm run test:bingo:browser: passed, including mobile layouts, chooser wiring, cancellation/retry, replacement, storage-failure recovery, and axe accessibility checks. No external requests or page errors.npm run typecheck: 0 errors, 0 warnings (45 existing hints).npm run buildandnpm run test:search:build: passed; 14 search-quality tests passed.node --import tsx --test tests/smoke/smoke.spec.ts: 29 passed. The npm/tsx invocation encountered local loopbackECONNRESETerrors in the redirects test; the direct Node invocation passed the full suite.git diff --check: passed.The initial
npm run checkreached prebuild before the sandbox blocked tsx's local IPC pipe. Build and subsequent checks were completed outside that restriction.Screenshots and device coverage
Viewed the supplied iPhone reference and local screenshots at 320 px and 390 px, including the same “If you want, I can…” square. The single button fits without clipping. Local review images are available as
mobile-photo-action.pngandmobile-photo-action-320.png; they are not committed or attached here.The native iOS chooser was not exercised on a physical phone. The existing upload input and handler are preserved unchanged, with no capture attribute; automated tests exercise the browser file-chooser event and simulate cancellation.
Checklist