Stdlib: AOT crc32() NestedJIT-safe bit-by-bit helper (#27077) - #27966
Merged
Conversation
Thin AOT returned 0 (then wrong CRC with table lookups) because Crc32JitHelper called VmCrc32 — NestedJIT stubs cross-class calls. Inline CRC32B/CRC32C with Bin2hex-style byteOrd and refresh the helper-runtime unit. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Aug 6, 2026
#27971) #27966/#27968/#27969 landed past the last verified-fresh argv seed, re-staling lowering_source_fingerprint (4f-m / #8713). Rebuild bin-compile-aot on tip (e363d9206231…, verified-fresh) — no restamp. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
PurHur
added a commit
that referenced
this pull request
Aug 6, 2026
#27973) #27966/#27968/#27969 landed past the last verified-fresh argv seed, re-staling lowering_source_fingerprint (4f-m / #8713). Rebuild bin-compile-aot on tip (e363d9206231…, verified-fresh) — no restamp. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Crc32JitHelperNestedJIT-safe (inline CRC32B/CRC32C bit-by-bit + Bin2hex-stylebyteOrd) so thin AOT no longer stubsVmCrc32→ 0 / wrong CRC.prelinked/helper-runtime/.../Crc32JitHelperunit; drop AotTest crc32c skip + Crc32c AOT skip comment.test/repro/issue_27077_crc32_aot.php.php-src:
ext/standard/crc32.c,ext/standard/hash_crc32.cCloses #27077
Test plan
php bin/vm.php/jit.php/ AOTcrc32('php-compiler')→4282364586(repeat 10)PHP_COMPILER_HELPER_RUNTIME_O=0and default helper-cache path both print4282364586vendor/bin/phpunit test/unit/Crc32BuiltinTest.php→ OK (incl. AOT)vendor/bin/phpunit test/unit/Crc32RuntimeShrinkTest.php→ OKvendor/bin/phpunit --filter 'data set "crc32"' test/aot/AotTest.php→ OKphp script/bootstrap-inventory.php --check→ OK 7078/7078make bootstrap-selfhost-vm-driver-execute-probe→ OKnorth-star5-verify --strict; master already red onnorth-star5-fast(gen-0 manifest/driver mismatch Self-host M5: bootstrap-inventory argv driver size floor — grow beyond 451KB stub #8713).crc32_type_errorAOT exit 134 fails on master too (pre-existing).Made with Cursor