Language: INF/NAN→int untyped coerce emits E_DEPRECATED (#27926) - #27969
Merged
Conversation
5 tasks
Match Zend zend_dval_to_lval for non-finite floats on bitwise and dim read paths (VM + JIT); keep typed weak int for #27925. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-27926-inf-nan-int-deprecated
branch
from
August 6, 2026 01:37
f76be48 to
fe5602a
Compare
4 tasks
PurHur
added a commit
that referenced
this pull request
Aug 6, 2026
#27971) #27966/#27968/#27969 landed past the last verified-fresh argv seed, re-staling lowering_source_fingerprint (4f-m / #8713). Rebuild bin-compile-aot on tip (e363d9206231…, verified-fresh) — no restamp. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
PurHur
added a commit
that referenced
this pull request
Aug 6, 2026
#27973) #27966/#27968/#27969 landed past the last verified-fresh argv seed, re-staling lowering_source_fingerprint (4f-m / #8713). Rebuild bin-compile-aot on tip (e363d9206231…, verified-fresh) — no restamp. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VmMath::floatLosesIntPrecision), matching Zendzend_dval_to_lvalE_DEPRECATED text (INF/-INF/NAN).!is_finite(round-trip fcmp misses poison fromfptosiof Inf/NaN); boxed float→long viafloatToLongWithPrecisionWarning; dim-read non-finite only (finite fractional silence remains Language: float array dim read/isset/unset silent — Zend E_DEPRECATED (re-#16739, Zend/zend_execute.c) #27948).intleft for Language: weak typed int accepts INF/NAN — Zend TypeError (zend_operators.c zend_dval_to_lval_safe) #27925 (no deprecation on that path).Closes #27926
Test plan
vendor/bin/phpunit test/compliance/InfNanToIntDeprecatedVMTest.phpvendor/bin/phpunit test/compliance/InfNanToIntDeprecatedJITTest.phpvendor/bin/phpunit test/compliance/ArrayFloatKeyWriteDeprecatedVMTest.phpfloat_bitwise_deprecateexpect still matches on VMci-fast/north-star5-verify-fast(pre-existing gen-0 mismatch Self-host M5: bootstrap-inventory argv driver size floor — grow beyond 451KB stub #8713 on master)Trust snapshot (pre-work)
bootstrap-inventory --check: OK 7078/7078release-readiness --json:north-star5-fastfail (gen-0 manifest/driver mismatch Self-host M5: bootstrap-inventory argv driver size floor — grow beyond 451KB stub #8713) — pre-existingphp-src reference
Zend/zend_operators.c—zend_dval_to_lval/ implicit float→long deprecationMade with Cursor