ci: stop installing pynufft in the release workflow - #259
Merged
Conversation
pynufft is no longer a dependency of any PyAuto library — PyAutoArray#475 deleted TransformerNUFFTPyNUFFT and dropped pynufft from both the `optional` and `dev` extras — but three steps here still installed `pynufft==2025.1.1`: release_test_pypi -> Tests run_smoke_tests -> Install from TestPyPI at pinned version release_workspaces -> Regenerate API audit baseline Nothing imports it, so this was install time and resolver surface only (the pin is 2025.1.1, not the 2022.2.2 that hits the scipy.linalg.pinv2 failure — no build was red). `numba` is kept at both sites where the two shared a line; the nearby "matplotlib deliberately unpinned" comments are about matplotlib and are untouched. Phase 3 of 3 of the pynufft-removal residue sweep. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q7kFdoYcD6wnTifNXV5T98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258 (phase 3 of 3 of the pynufft-removal residue sweep — this is the PyAutoHands leg; PyAutoHeart and PyAutoCTI carry their own PRs, and the three are independent).
What changed
pynufftis no longer a dependency of any PyAuto library — PyAutoArray#475 deletedTransformerNUFFTPyNUFFTand droppedpynufftfrom both theoptionalanddevextras — but three steps inrelease.ymlstill installedpynufft==2025.1.1:release_test_pypipip install pynufft==2025.1.1pytest,numbaunchanged)run_smoke_testspip install pynufft==2025.1.1 numbapip install numbarelease_workspacespip install pynufft==2025.1.1 numbapip install numbanumbais kept at both shared sites. The neighbouring "matplotlib deliberately unpinned" comments are about matplotlib, not pynufft, and are untouched. Nothing else in this repo mentions pynufft (full-tree grep).Why this is low-risk, and not urgent
Every site pinned 2025.1.1, not the broken
2022.2.2— so none of them was hitting thescipy.linalg.pinv2failure and no run was red. What this removes is install time and unnecessary resolver surface on every release and rehearsal run. Nothing in the stack imports pynufft, so no step loses a dependency it uses.Verification
Ordinary PR CI cannot exercise these lines:
release.ymlisworkflow_dispatch-only, theTestsstep runs in rehearsal and live mode, andrun_smoke_tests/release_workspacesare live-release-only. So the pre-merge signal is this repo's own PR checks plus the diff; full confirmation lands on the next release rehearsal / nightly release run, which is where these steps actually execute.Generated by Claude Code