feat: upload the smoke report dir so per-script timings persist - #167
Merged
Conversation
PyAutoHands#264 has the runner write a consolidated `smoke_timings.json` into its report dir on every report write — one row per executed script/notebook with the runner's own measured duration, the cap in force and the exit code. That file dies with the job unless something uploads it, and the job log it would otherwise be scraped from ages out with log retention. Uploading it here, in the reusable workflow, means the dataset accumulates for every gate run across all ten workspaces at once, with no per-repo change. The path is a glob rather than one literal directory because this workflow does not pass `--report-dir`: each workspace's own `.github/scripts/run_smoke.py` does, and the runner script is deliberately left in the workspace (see the file header). `test-results/` is the house name — what workspace-validation.yml passes to its own `run_python.py` invocations — and the second pattern catches a workspace that named its report dir something else. `if: always()` plus `if-no-files-found: ignore` are both load-bearing. A docs-only change skips the matrix entirely and a crash before the first report write leaves no report dir at all; neither is a reason to fail a gate. An upload that failed closed would turn "we collected no timings" into "the PR is red", which is backwards. No `retention-days`, so the dataset keeps the repo's full default retention rather than a shortened window. The step sits ahead of the Slack notifier so a failing run's timings — the most interesting ones — are collected rather than skipped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EoDPz2LevKeBaDwqFKtZrU
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PyAutoLabs/PyAutoHands#264 (phase 2 of the test-performance board arc, #163) — the workflow half of PyAutoLabs/PyAutoHands#265: with the runner now emitting
smoke_timings.jsonper gate run, this makes the dataset persist.smoke-tests.ymlgains anactions/upload-artifact@v4step between the runner and the Slack notifier:name: smoke-timings-${{ matrix.python-version }},if: always(),if-no-files-found: ignore— a docs-only skipped run or a pre-report crash never fails on the upload.test-results/plus**/smoke_timings.json), not one literal directory: the reusable workflow doesn't pass--report-dir— each workspace's ownrun_smoke.pydoes — so a workspace using another report-dir name still lands its timings with no per-repo edit.retention-days: the timing dataset keeps the repo's full default artifact retention (unlikeworkspace-validation.yml's 30-day transient artifacts).Tests: 576 passed (+3 workflow-wiring assertions).
🤖 Generated with Claude Code
https://claude.ai/code/session_01EoDPz2LevKeBaDwqFKtZrU
Generated by Claude Code