feat: remove fit_quick.png — quick updates write the normal fit subplot - #682
Merged
Conversation
Collaborator
Author
|
Added |
Collaborator
Author
|
Workspace follow-up PR: PyAutoLabs/autolens_workspace_test#241 (merge this library PR first — library-first gate). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #680. Quick updates during a non-linear search previously wrote a special lighter-weight
fit_quick.pngfor every PyAutoLens dataset type, so the user had to visually recognise two different fit-plot layouts for the same fit. Thequick_update=Truepath in the four model plotters (imaging, interferometer, point, weak) now writes the normal fit subplot and returns, still skipping the heavy extras (log10 / planes / tracer / dirty-image variants / FITS). The five quick figure functions are deleted. PyAutoGalaxy already behaved this way; companion PyAutoFit PR reduces the live-display candidate list tofit.png.API Changes
Quick updates now write the normal fit subplot file (
fit.pngfor imaging/interferometer/point,subplot_fit_weak.pngfor weak) instead offit_quick.png; the module-level quick figure functions are removed (none were exported in theapltnamespace). See full details below.Test Plan
test_autolens/full suite: 498 passedorigin/main(includes Point-source phase A: PairAll log-sum-exp stabilization + free-centre tensor option #679) before push; no conflictsautolens_workspace_testvisualization-jit scripts that assertfit_quick.pngFull API Changes (for automation & release notes)
Removed
autolens.imaging.plot.fit_imaging_plots.subplot_fit_quick— quick path now callssubplot_fit(plainfit.png, final plane as source, any plane count)autolens.imaging.plot.fit_imaging_plots.subplot_fit_combined_quick— had no callersautolens.interferometer.plot.fit_interferometer_plots.subplot_fit_quick— quick path now callssubplot_fitautolens.point.plot.fit_point_plots.subplot_fit_quick— quick path now callssubplot_fit(with critical-curve overlays)autolens.weak.plot.fit_weak_plots.subplot_fit_quick— quick path now callssubplot_fit_weakNone of these were exported via
autolens.plot(aplt) or the aggregator.Changed Behaviour
PlotterImaging.fit_imaging(quick_update=True)— writes the normal 12-panelfit.png(single normal subplot even for >2-plane tracers, so the live display always has one canonical filename)PlotterInterferometer.fit_interferometer(quick_update=True)— always writes the normalfit.png, then returns before tracer/dirty/real-space extrasPlotterPoint.fit_point(quick_update=True)— writes the normalfit.pngincluding critical-curve/caustic overlaysPlotterWeak.fit_weak(quick_update=True)— writes the normalsubplot_fit_weak.png(note: the live viewer only resolvesfit.png, so weak fits no longer surface in the live display — pre-existing filename quirk of the weak module)fit_quick.pngMigration
fit_quick.pngfor search progressfit.png(the same file the full visualization writes)Shipped under human-authorized Heart-RED override; RED reason (verbatim, unrelated nightly):
release validation FAILED (stage integrate).Generated by the PyAutoLabs agent workflow.