Skip to content

Fix: enabled cupy backend for sinc interp with tol (=sparse matrix)#767

Open
mrava87 wants to merge 1 commit into
PyLops:devfrom
mrava87:fix-sinccupy
Open

Fix: enabled cupy backend for sinc interp with tol (=sparse matrix)#767
mrava87 wants to merge 1 commit into
PyLops:devfrom
mrava87:fix-sinccupy

Conversation

@mrava87

@mrava87 mrava87 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes a recently introduced bug in _sincinterp when tol is not None for Cupy arrays.

Instead of using directly scipy's csr_matrix this is now wrapped into one of our deps method dispatching the scipy/cupyx method based on the type of the sinc array.

TODO:

  • add Cupy backend to test_interpolation (so far only run on Numpy arrays)

@mrava87 mrava87 added the bug Something isn't working label Jul 1, 2026
@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 critical

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
ErrorProne 1 critical

View in Codacy

🟢 Metrics 5 complexity · 0 duplication

Metric Results
Complexity 5
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant