Skip to content

ci: relax ordering assertion in test_detached_drop_is_collected_on_next_attach - #6320

Open
davidhewitt wants to merge 1 commit into
PyO3:mainfrom
davidhewitt:flaky-decref-next-attach
Open

ci: relax ordering assertion in test_detached_drop_is_collected_on_next_attach#6320
davidhewitt wants to merge 1 commit into
PyO3:mainfrom
davidhewitt:flaky-decref-next-attach

Conversation

@davidhewitt

Copy link
Copy Markdown
Member

Closes #6318

As per discussion in that thread, it's possible that better test isolation with cargo nextest is worth doing in CI. However, I think for now adding a retry loop is somewhat good enough to make the test suite run approximately correctly under cargo test.

@davidhewitt
davidhewitt force-pushed the flaky-decref-next-attach branch from 59a90d9 to 745a5a1 Compare August 13, 2026 20:29
@davidhewitt davidhewitt changed the title relax ordering assertion in test_detached_drop_is_collected_on_next_attach ci: relax ordering assertion in test_detached_drop_is_collected_on_next_attach Aug 13, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 13, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 30.55%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 5 improved benchmarks
✅ 142 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime nested_attach_scaling/empty_pool[1] 4 ns 3 ns +33.33%
WallTime nested_attach_scaling/empty_pool[2] 4 ns 3 ns +33.33%
WallTime nested_attach_scaling/sparse_pool[1] 4 ns 3 ns +33.33%
WallTime nested_attach_scaling/sparse_pool[2] 4 ns 3 ns +33.33%
WallTime nested_attach_scaling/empty_pool[4] 6 ns 5 ns +20%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing davidhewitt:flaky-decref-next-attach (745a5a1) with main (dfdbc46)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: Pending decref pool is not always processed on next attach

1 participant