ci: relax ordering assertion in test_detached_drop_is_collected_on_next_attach - #6320
Open
davidhewitt wants to merge 1 commit into
Open
ci: relax ordering assertion in test_detached_drop_is_collected_on_next_attach#6320davidhewitt wants to merge 1 commit into
test_detached_drop_is_collected_on_next_attach#6320davidhewitt wants to merge 1 commit into
Conversation
davidhewitt
force-pushed
the
flaky-decref-next-attach
branch
from
August 13, 2026 20:29
59a90d9 to
745a5a1
Compare
test_detached_drop_is_collected_on_next_attachtest_detached_drop_is_collected_on_next_attach
Merging this PR will improve performance by 30.55%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | nested_attach_scaling/empty_pool[1] |
4 ns | 3 ns | +33.33% |
| ⚡ | WallTime | nested_attach_scaling/empty_pool[2] |
4 ns | 3 ns | +33.33% |
| ⚡ | WallTime | nested_attach_scaling/sparse_pool[1] |
4 ns | 3 ns | +33.33% |
| ⚡ | WallTime | nested_attach_scaling/sparse_pool[2] |
4 ns | 3 ns | +33.33% |
| ⚡ | WallTime | nested_attach_scaling/empty_pool[4] |
6 ns | 5 ns | +20% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing davidhewitt:flaky-decref-next-attach (745a5a1) with main (dfdbc46)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6318
As per discussion in that thread, it's possible that better test isolation with
cargo nextestis worth doing in CI. However, I think for now adding a retry loop is somewhat good enough to make the test suite run approximately correctly undercargo test.