perf: accelerate uchardet language and candidate analysis - #110
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The uchardet changes are in PyYoshi/uchardet@7993e0a. No public C or Python API is removed or changed.
Performance
Direct uchardet C API benchmark, 158 bundled fixtures preloaded before timing (Clang Release, median of 200 samples):
On 19 charset-normalizer sample files, the native median fell from 19.777 ms to 8.694 ms (56.0%).
A rigorous 166-file / 641,202-byte Python benchmark with native acceleration enabled measured:
The same benchmark using the sibling projects pure fallback paths is documented separately so charset-normalizer Cython and chardet mypyc builds are not conflated with their Python fallbacks.
Compatibility and validation
Notes
The benchmark intentionally calls the public uchardet C API directly and preloads input data, avoiding Python and filesystem overhead while tuning the native implementation. The Python benchmark remains as an end-to-end comparison among cChardet, chardet, and charset-normalizer.