Repository navigation
Conversation
… ids Newer products (a226, a296, ...) are listed in home_data with a string product id only. _plugin_product_ids() only accepted ints, so the import sent no ids and stored "no product ids available" for appplugin. Sending the string itself does not help: /api/v1/appplugin answers code 1002 "parameter error". The cloud still has a numeric id per model. When home_data has a string product id, the import now reads GET /api/v5/product, maps each string id to its model's numeric id and asks appplugin for those. Checked against the EU cloud with a Saros 20 Neo (roborock.vacuum.a296): its string id maps to 257, and appplugin answers plugin version 7052. Refs Python-roborock#221 (the string-id half; per-platform plugins are not touched). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Newer products (a226, a296, ...) are listed in
home_datawith a string product id only._plugin_product_ids()only accepted ints, so the cloud import sent no ids to/api/v1/apppluginand stored "no product ids available". The app then has no device plugin for these robots. Sending the string itself does not work:apppluginanswers code 1002 "parameter error".The cloud still has a numeric id for each model. When
home_datacontains a string product id, the import now readsGET /api/v5/product, maps each string id to its model's numeric id, and asksapppluginfor those. Accounts with only numeric ids behave exactly as before; the extra request is only made when a string id is present.Testing
tests/test_plugin_product_ids.py(numeric ids unchanged, string ids mapped through the catalog, unmapped strings left out, nested catalog shapes).roborock.vacuum.a296): its string id maps to 257,apppluginanswers plugin version 7052, and the official app loads the device page through the local server. This has been running on my install since.Refs #221 (the string-id half only; the per-platform plugin part of that issue is not touched).
🤖 Generated with Claude Code