Skip to content

Commit 6934f7f

Browse files
committed
fix(a01): skip DP 225 on Zeo H1 Neo
Exclude DEFAULT_SETTING from the initial force-load query for roborock.wm.a90, matching the existing H1 workaround. The device does not return DP 225, so requiring it prevents setup from completing. Test both affected models, keep other model support unchanged, and retain the remaining softener DPs in the query. Fixes #996
1 parent 5787a6f commit 6934f7f

2 files changed

Lines changed: 12 additions & 7 deletions

File tree

‎roborock/devices/traits/a01/device_feature.py‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,10 +143,13 @@
143143
}
144144
)
145145

146-
# Devices known to lack DEFAULT_SETTING (DP 225).
146+
# Devices known to lack DEFAULT_SETTING (DP 225). These models have a softener
147+
# compartment but never answer the DP 225 query, so requesting it stalls the
148+
# force-load until it times out.
147149
_UNSUPPORTED_DEFAULT_SETTING: frozenset[str] = frozenset(
148150
{
149151
"roborock.wm.a63", # H1
152+
"roborock.wm.a90", # H1 Lite / H1 Neo
150153
}
151154
)
152155

@@ -250,7 +253,7 @@ def supports_feature_bits(model: str | None) -> bool:
250253

251254

252255
def supports_default_setting(model: str | None) -> bool:
253-
"""H1 (a63) does not support DP 225 even though it has a softener compartment."""
256+
"""H1 (a63) and H1 Lite (a90) do not support DP 225 despite having a softener compartment."""
254257
if model is None:
255258
return True # conservative: assume yes
256259
return model not in _UNSUPPORTED_DEFAULT_SETTING

‎tests/devices/traits/a01/test_device_feature.py‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,20 @@
1111
[
1212
("roborock.wm.a63", False), # H1
1313
("roborock.wm.a102", True), # H1 Overseas
14-
("roborock.wm.a90", True), # H1 Lite
14+
("roborock.wm.a90", False), # H1 Lite / H1 Neo
15+
("roborock.wm.a91", True), # H1 Lite Overseas
1516
(None, True), # unknown model: assume supported
1617
],
1718
)
1819
def test_supports_default_setting(model: str | None, expected: bool) -> None:
19-
"""DP 225 is unsupported on H1 (a63) only."""
20+
"""DP 225 is unsupported on H1 (a63) and H1 Lite (a90)."""
2021
assert supports_default_setting(model) is expected
2122

2223

23-
def test_force_load_omits_default_setting_for_h1() -> None:
24-
"""H1 (a63) has a softener compartment but must not be queried for DP 225."""
25-
dp_list = build_force_load_dp_list("roborock.wm.a63")
24+
@pytest.mark.parametrize("model", ["roborock.wm.a63", "roborock.wm.a90"])
25+
def test_force_load_omits_default_setting_for_h1(model: str) -> None:
26+
"""H1 variants have a softener compartment but must not be queried for DP 225."""
27+
dp_list = build_force_load_dp_list(model)
2628

2729
assert RoborockZeoProtocol.DEFAULT_SETTING not in dp_list
2830
# The remaining softener DPs are still queried.

0 commit comments

Comments
 (0)