Repository navigation
Conversation
infy1995
force-pushed
the
feat/v1-product-nicknames
branch
from
November 15, 2026 20:34
d217801 to
ccf43c0
Compare
This was referenced Nov 16, 2026
Lash-L
reviewed
Nov 18, 2026
Lash-L
left a comment
Collaborator
There was a problem hiding this comment.
Automated code review by Gemini 4 Hydrogen in Antigravity using our /review (/code-review) skill (.agents/skills/code-review/SKILL.md / AGENTS.md).
No defects found; the PR is clean and ready to approve.
Summary by Layer
- Priority 1: Public Trait APIs & Consumer Contracts —
RoborockProductNickname(roborock/data/code_mappings.py) andDeviceFeatures/PRODUCT_FEATURE_MAP(roborock/device_features.py) preserve strong typing andRoborockBaseinheritance. All new product nicknames (BERYL*,CRAG,CORALPROS,CORALPROSAW,HERA,PANDORA,PEARLCLITE,PEARLEH,PEARLFPRO,QUINN*,R50,TALCSC,VERDELITES,VIDA*,VIVIAN*), their short-model tuples, and the short-model additions toCORALPROandVIVIANCmatch the app's model configuration without duplicate short models or regressions to existing nicknames. - Priority 2: Data Lifecycle & State Management —
DeviceFeatures.from_feature_flagsremains a pure value-returning factory. Updatingis_support_water_modeandis_customized_clean_supportedto includeis_roller_mop_supportedmatches the app's capability gating for roller-mop models (which lack a mop-module product feature), alongsideis_clean_route_setting_supported. - Priority 3: Wire Protocols & Resilient Enums —
HomeDataProduct.product_nicknameretains itsPEARLPLUSfallback for unrecognized models. - Tests & Docs — Colocated unit tests (
tests/data/test_code_mappings.py,tests/data/test_containers.py,tests/test_supported_features.py,tests/test_cli.py), per-nicknamePRODUCT_FEATURE_MAPsnapshots (tests/__snapshots__/test_supported_features.ambr),device_info.yaml,SUPPORTED_FEATURES.md, anddocs/V1_DEVICE_FEATURES.mdare all consistent. Targetedpytest(226 passed, 78 snapshots passed) andruff checkpassed on the PR worktree, andmypyreported zero errors on all modified files.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #738 (dock controls): the per-model option lists need these product nicknames.
Adds the V1 vacuum product nicknames that
RoborockProductNicknamelacked, with their base product features. Today these models fall back toPEARLPLUS, so they get Qrevo MaxV product features they do not have, for example the remote view.The nicknames, short models and features were compared with the model configuration in the current Roborock app V1 plugins. Combining each product's own features with the features it inherits, minus the same exclusion lists as
PRODUCTS_WITHOUT_*, reproduces the library's existing entries, and the new entries are derived the same way.New nicknames
BERYL_FEATURES(Max+, RGB camera)VIVIANSPROC_FEATURES(Max+, RGB camera, spin mop)PEARL_PLUS_FEATURESPEARL_FEATURESExisting nicknames also get the short models that belong to them:
VIVIANC+ a186, a187, a209, a210, a246;CORALPRO+ a231, a232, a236, a308.None of the new products joins a
PRODUCTS_WITHOUT_*set. Existing nicknames keep exactly their features: the first commit adds a per-nickname snapshot ofPRODUCT_FEATURE_MAPgenerated onmain, and those entries do not change.PEARLELITE(a169/a170) keeps its name; newer app versions call itPearlEPro, with the same features.Roller-mop models
The Beryl products (e.g. P30 Pro a306, Saros 20 Flow a307, Qrevo Curv 2 Flow a245) use a roller mop and have no mop-module product feature, so today they get no water modes and no custom clean mode although they mop.
is_support_water_modeandis_customized_clean_supportednow also followis_roller_mop_supported, asis_clean_route_setting_supportedalready does, so the roller mop counts as a mop module like a shake or spin mop.Behaviour changes
Models that used to fall back to
PEARLPLUSnow get their own features:PEARL_PLUS_FEATURES(and the VivianC extras) no longer reportis_new_remote_view_supported, because they have no remote view.The existing test samples affected are the P30 Pro (a306) and the Qrevo 2 Pro (a294, now
QUINN):is_new_remote_view_supportedTrue -> False. The device-info CLI test now expectsQUINNfor a294 and keeps an unrecognised model forUnknown. Device features are cached, so existing installs keep their old values until the cache is rebuilt; recomputing them from the cached raw flags could be a follow-up.Three existing entries differ from the app plugin and are left unchanged here: TOPAZSPOWER (remote view), TANOSSPLUS (3D map) and ULTRONSE (no electronic mop or pure clean mop). Happy to follow up separately.
Overlap with open PRs
QUINN, which has a single-line camera and no RGB camera. This may also help there.SUPPORTED_FEATURES.md; the a187 cell (VIVIANC) only needs a regeneration after either PR lands.Happy to rebase on either of them.
Test plan
uv run pre-commit run --all-filesuv run pytestPRODUCT_FEATURE_MAPsnapshot, short model to nickname table, short-model uniqueness,product_nicknamefallback, roller-mop water mode and custom clean.Related issues
QUINN).