Skip to content

feat: add V1 dock types 48 and 50 and fix F2R, K1S and Hera dock capabilities - #1047

Open
infy1995 wants to merge 1 commit into
Python-roborock:mainfrom
infy1995:feat/v1-dock-types-from-app
Open

infy1995 wants to merge 1 commit into
Python-roborock:mainfrom
infy1995:feat/v1-dock-types-from-app

Conversation

@infy1995

@infy1995 infy1995 commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds the V1 dock types that the library did not know and fixes three dock capabilities, so dock options can be gated on the right dock.

  • New dock type codes f1rc_dock = 48 and f2rs_dock = 50. Until now these codes fell back to unknown, so the dock counted as missing and no dock traits were offered.
  • Capabilities for codes 48, 49 and 50 (F1RC, F1RS, F2RS): collect, wash and dry, high-temperature water, double serial communication, simple wash modes, no-water-flow carousel (49, 50), carousel self-clean (48 without AM) and water up/down drain (AM variants of 49 and 50).
  • Aliases with the dock names for two placeholder members: shell_4_dock (27) and f1rs_dock (49). type_27_dock and type_49_dock stay the canonical names, so .name, keys() and existing code are unchanged.
  • New dock properties:
    • is_no_support_hot_wash_towel (Shell E): this dock cannot wash mops with hot water even when the robot reports hot mop washing.
    • is_multi_clean_fluid_supported (Shell 4S without AM).
    • is_clean_carousel_supported (dock has a carousel/strainer).
  • Docs: new "Dock Features" section in docs/V1_DEVICE_FEATURES.md. It explains that the "A"/"AM" dock variants (Shell 2SA, O5AM, ...) are not separate codes: they report the same dock_type and differ by Status.has_am.

The dock list and capabilities were compared with the dock table in the newest Roborock app V1 plugins and now match it.

Changed existing values

These results change for docks the library already knew.

Dock Capability Before After Reason
F2R (43) is_clean_carousel_self_clean_supported True False The newest app plugins no longer offer carousel self-clean for F2R. Older plugins did.
K1S (20), without AM is_clean_fluid_auto_delivery_supported False True The newest app plugins add automatic fluid delivery to K1S. The AM variant was already True.
Hera (24) is_hatch_door_dock_cool_fan_supported False True The Hera dock has the hatch door cooling fan, like Couple; every app plugin that knows Hera treats it so.

Known difference, not changed here

is_special_support_wash_temp is True only for the Shell 2E Lite dock. Whether wash temperature is offered also depends on the product: every product except the PearlE Pro gets it, and the PearlE Pro only with a Shell 2E Lite dock. The library does not use this property yet. It will be fixed when the wash temperature options start using it.

Testing

  • Table-driven tests in tests/test_supported_features.py for each new code and changed value, with and without AM, and for the aliases.
  • pre-commit run --all-files and the full pytest suite pass.

Part of #738

Add dock type codes 48 (F1RC) and 50 (F2RS), app-name aliases for codes 27 and 49, the capabilities of codes 48-50, and three new dock properties. K1S gets automatic fluid delivery, Hera the hatch-door cool fan, and F2R no longer reports carousel self-cleaning, following the newest app plugins.
@Lash-L Lash-L added Feature New feature Data model changes Changes to data models, device info, or feature mappings V1 V1 platform labels Nov 15, 2026
@infy1995 infy1995 changed the title feat: add new V1 dock types and align dock capabilities with the app feat: add V1 dock types 48 and 50 and fix F2R, K1S and Hera dock capabilities Nov 17, 2026

@Lash-L Lash-L left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated code review by Gemini 4 Hydrogen in Antigravity using our /review (/code-review) skill (.agents/skills/code-review/SKILL.md / AGENTS.md).

Summary

No blocking issues or defects found — this PR is clean and ready to approve.

  • Priority 1 & 2 (Public Contracts & Feature Gating — roborock/device_features.py, docs/V1_DEVICE_FEATURES.md):
    • Verified all dock capability sets and properties (is_no_support_hot_wash_towel, is_multi_clean_fluid_supported, is_clean_carousel_supported, and the updates for F2R, K1S, Hera, F1RC, F1RS, F2RS) against the Roborock app's 72 dock configurations (both AM and non-AM variants). Every capability matches the app's dock table and getters.
    • is_special_support_wash_temp is accurately documented as covering the dock-only portion of the app's check.
  • Priority 3 (Wire Codes & Enums — roborock/data/v1/v1_code_mappings.py):
    • Verified all RoborockDockTypeCode values (0–3, 5–11, 13–24, 26–35, 37–46, 48–50): no app dock codes are missing. f1rc_dock = 48 and f2rs_dock = 50 match the app names, and aliases shell_4_dock = 27 and f1rs_dock = 49 preserve canonical .name and iteration behavior.
  • Tests & Tooling (tests/test_supported_features.py):
    • Table-driven @pytest.mark.parametrize tests cover the new codes, aliases, AM/non-AM variants, and changed capabilities.
    • pytest tests/test_supported_features.py tests/conformance/ (541 passed, 53 xfailed, 11 snapshots passed) and ruff check on the changed Python files pass.

@Lash-L Lash-L added /review run Code review skill (/review) has been run Passed /review Passed the /review skill check labels Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Data model changes Changes to data models, device info, or feature mappings Feature New feature Passed /review Passed the /review skill check /review run Code review skill (/review) has been run V1 V1 platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants