Repository navigation
Conversation
Add dock type codes 48 (F1RC) and 50 (F2RS), app-name aliases for codes 27 and 49, the capabilities of codes 48-50, and three new dock properties. K1S gets automatic fluid delivery, Hera the hatch-door cool fan, and F2R no longer reports carousel self-cleaning, following the newest app plugins.
This was referenced Nov 14, 2026
Lash-L
reviewed
Nov 18, 2026
Lash-L
left a comment
Collaborator
There was a problem hiding this comment.
Automated code review by Gemini 4 Hydrogen in Antigravity using our /review (/code-review) skill (.agents/skills/code-review/SKILL.md / AGENTS.md).
Summary
No blocking issues or defects found — this PR is clean and ready to approve.
- Priority 1 & 2 (Public Contracts & Feature Gating —
roborock/device_features.py,docs/V1_DEVICE_FEATURES.md):- Verified all dock capability sets and properties (
is_no_support_hot_wash_towel,is_multi_clean_fluid_supported,is_clean_carousel_supported, and the updates forF2R,K1S,Hera,F1RC,F1RS,F2RS) against the Roborock app's 72 dock configurations (both AM and non-AM variants). Every capability matches the app's dock table and getters. is_special_support_wash_tempis accurately documented as covering the dock-only portion of the app's check.
- Verified all dock capability sets and properties (
- Priority 3 (Wire Codes & Enums —
roborock/data/v1/v1_code_mappings.py):- Verified all
RoborockDockTypeCodevalues (0–3, 5–11, 13–24, 26–35, 37–46, 48–50): no app dock codes are missing.f1rc_dock = 48andf2rs_dock = 50match the app names, and aliasesshell_4_dock = 27andf1rs_dock = 49preserve canonical.nameand iteration behavior.
- Verified all
- Tests & Tooling (
tests/test_supported_features.py):- Table-driven
@pytest.mark.parametrizetests cover the new codes, aliases, AM/non-AM variants, and changed capabilities. pytest tests/test_supported_features.py tests/conformance/(541 passed, 53 xfailed, 11 snapshots passed) andruff checkon the changed Python files pass.
- Table-driven
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the V1 dock types that the library did not know and fixes three dock capabilities, so dock options can be gated on the right dock.
f1rc_dock = 48andf2rs_dock = 50. Until now these codes fell back tounknown, so the dock counted as missing and no dock traits were offered.shell_4_dock(27) andf1rs_dock(49).type_27_dockandtype_49_dockstay the canonical names, so.name,keys()and existing code are unchanged.is_no_support_hot_wash_towel(Shell E): this dock cannot wash mops with hot water even when the robot reports hot mop washing.is_multi_clean_fluid_supported(Shell 4S without AM).is_clean_carousel_supported(dock has a carousel/strainer).docs/V1_DEVICE_FEATURES.md. It explains that the "A"/"AM" dock variants (Shell 2SA, O5AM, ...) are not separate codes: they report the samedock_typeand differ byStatus.has_am.The dock list and capabilities were compared with the dock table in the newest Roborock app V1 plugins and now match it.
Changed existing values
These results change for docks the library already knew.
is_clean_carousel_self_clean_supportedis_clean_fluid_auto_delivery_supportedis_hatch_door_dock_cool_fan_supportedKnown difference, not changed here
is_special_support_wash_tempis True only for the Shell 2E Lite dock. Whether wash temperature is offered also depends on the product: every product except the PearlE Pro gets it, and the PearlE Pro only with a Shell 2E Lite dock. The library does not use this property yet. It will be fixed when the wash temperature options start using it.Testing
tests/test_supported_features.pyfor each new code and changed value, with and without AM, and for the aliases.pre-commit run --all-filesand the fullpytestsuite pass.Part of #738