Repository navigation
feat(v1): generalize segment clean mode updates and preserve existing settings - #1050
Draft
allenporter wants to merge 1 commit into
Draft
allenporter wants to merge 1 commit into
allenporter wants to merge 1 commit into
Conversation
allenporter
force-pushed
the
fix/customize-clean-mode-followup
branch
4 times, most recently
from
November 14, 2026 23:37
d8bcbb9 to
389b0a3
Compare
allenporter
marked this pull request as draft
November 15, 2026 04:43
allenporter
force-pushed
the
fix/customize-clean-mode-followup
branch
2 times, most recently
from
November 16, 2026 05:07
b1b2f07 to
db4a64e
Compare
allenporter
force-pushed
the
fix/customize-clean-mode-followup
branch
from
November 16, 2026 05:09
db4a64e to
58f99e7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #984 for
CustomizeCleanModeTrait:set_segment_clean_modeand preserve existing settings on partial updates:CustomizeCleanModeTrait.set_segment_clean_mode(segment, *, fan_power=None, water_box_mode=None, mop_mode=None, repeat=None, clean_then_mop=None)so V1 devices that support per-room custom modes (is_customized_clean_supported) without clean-then-mop (is_clean_then_mop_mode_supported=False, e.g. S7 MaxV, S8, Q Revo) can also configure per-room suction, water flow, route, and repeat count.repeat=2to1or requiring callers to re-supply unchanged modes). When adding an override for a room without an existing entry,fan_power,water_box_mode, andmop_modeare required andrepeatdefaults to1.set_clean_then_mopas a backwards-compatible wrapper with optional mode/repeat arguments.self.modes is None, relying on the post-writerefresh()once loaded.repeatvalues:CUSTOMIZED106/204/302andSMART_MODE110/209/306) andrepeat < 1(or empty updates) withValueErrorbefore sending an RPC.