Skip to content

feat(v1): add CleanSequenceTrait for the room cleaning order - #1062

Open
cptntrps wants to merge 1 commit into
Python-roborock:mainfrom
cptntrps:feat/clean-sequence-trait
Open

cptntrps wants to merge 1 commit into
Python-roborock:mainfrom
cptntrps:feat/clean-sequence-trait

Conversation

@cptntrps

Copy link
Copy Markdown

Summary

Adds CleanSequenceTrait (device.v1_properties.clean_sequence) for the order in which a device cleans rooms.

  • refresh() reads get_clean_sequence into CleanSequence.rooms (segment ids in cleaning order).
  • set_order(rooms) writes set_clean_sequence. It refuses an empty list or a repeated room before anything is sent.
  • Gated on is_order_clean_supported (robot feature 123), the same pattern as the other optional traits.

Tested on a Saros 10R (a144)

Step Result
get_clean_sequence [8, 3, 7, 10, 1, 9]
app_segment_clean of rooms 8 and 7 with that order, two runs the robot cleaned room 8 first both times
set_clean_sequence [7, 8, 3, 10, 1, 9], then the same clean the robot cleaned room 7 first
set_clean_sequence while the robot was returning to the dock -10007 invalid status; accepted again once docked

The device reports feature 123 in app_get_init_status, so is_order_clean_supported is True on it. SUPPORTED_FEATURES.md currently shows no X for a144 in that row; the fixture data and this device's firmware may differ.

Checks

  • uv run pytest: 2371 passed
  • ruff check and ruff format --check: clean
  • mypy: no errors in the changed files

Reads get_clean_sequence into CleanSequence.rooms and writes it with
set_clean_sequence. Gated on is_order_clean_supported (robot feature 123).
@Lash-L Lash-L added Small PR Small pull request (<200 lines) Feature New feature V1 V1 platform labels Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature Small PR Small pull request (<200 lines) V1 V1 platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants