Repository navigation
Conversation
Reads get_clean_sequence into CleanSequence.rooms and writes it with set_clean_sequence. Gated on is_order_clean_supported (robot feature 123).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
CleanSequenceTrait(device.v1_properties.clean_sequence) for the order in which a device cleans rooms.refresh()readsget_clean_sequenceintoCleanSequence.rooms(segment ids in cleaning order).set_order(rooms)writesset_clean_sequence. It refuses an empty list or a repeated room before anything is sent.is_order_clean_supported(robot feature 123), the same pattern as the other optional traits.Tested on a Saros 10R (a144)
get_clean_sequence[8, 3, 7, 10, 1, 9]app_segment_cleanof rooms 8 and 7 with that order, two runsset_clean_sequence [7, 8, 3, 10, 1, 9], then the same cleanset_clean_sequencewhile the robot was returning to the dock-10007 invalid status; accepted again once dockedThe device reports feature 123 in
app_get_init_status, sois_order_clean_supportedis True on it.SUPPORTED_FEATURES.mdcurrently shows no X for a144 in that row; the fixture data and this device's firmware may differ.Checks
uv run pytest: 2371 passedruff checkandruff format --check: cleanmypy: no errors in the changed files