Repository navigation
Conversation
This was referenced Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RoborockDockFeatures.is_dryableis derived from the dock type alone, so docks in_COLLECT_WASH_DOCK_TYPESare never considered dryable.o3_dock(the Empty Wash Fill dock used by the S7 MaxV Ultra) is one of them, but it supports the separately sold dryer module (HADM02RR). A device with that module installed advertisesis_supported_drying: true.Today that means
MopDryerTraitis never created for these devices, so consumers such as Home Assistant never see the dock drying controls, and the "Mop drying remaining time" sensor staysunknown.Fixes #1037.
Change
RoborockDockFeaturesgains an optionalsupports_dryingfield, populated from the device'sis_supported_dryingfeature during trait discovery.is_dryablereturns true for dry-capable dock families as before, or when the device advertises drying support.Dock families that dry on their own are unaffected, because
is_collect_wash_dryis still checked first, and devices that don't advertise the feature keep the previous behaviour since the field defaults toNone.Verification
Unit tests added for the capability matrix (
tests/test_supported_features.py) and for the trait gate (tests/devices/traits/v1/test_mop_dryer.py).Verified against a real S7 MaxV (
roborock.vacuum.a27, firmware02.59.36) with ano3_dockand the HADM02RR module installed.Before:
After:
uv run pytest(2365 passed, 53 xfailed),ruffclean,mypyunchanged frommain(the 19 reported errors are pre-existing and none are in the touched files).