Repository navigation
Phase 623: genuine signed end-to-end IRC adversarial trials and verified CI evidence - #623
Conversation
…al loopback IRC sockets
…t trial inventories
…rify JUnit receipts
…un evidence limits
Reviewer's GuideThis PR validates the previously integrated signed evidence, capability, firewall, IRC, and one-use replay protections through genuine Ed25519 signing and two-client loopback socket execution, then applies an independent exact-head JUnit inventory check and per-run receipt workflow. It deliberately limits claims to the non-sensitive NOTICE boundary and documents remaining limitations and required CI/review gates. Sequence diagram for the Phase 623 signed IRC adversarial trialsequenceDiagram
participant C1 as IRCClient1
participant S as IRCServer
participant V as VerifierPinnedContext
participant L as ObservationReplayLedger
participant C2 as IRCClient2
C1->>S: IRC command with signed UFF evidence and grant
S->>V: Verify signed experiment and capability
V-->>S: Valid pinned evidence
S->>L: Admit operation identity
L-->>S: ALLOW
S-->>C1: NOTICE protected observation
S-->>C2: No protected output
C1->>S: Replay same operation
S->>L: Admit operation identity
L-->>S: REPLAYED_OPERATION
S-->>C1: No NOTICE
C1->>S: Forged, transplanted, revoked, or policy-mismatched evidence
S->>V: Verify evidence and composition
V-->>S: Denied
S->>L: Record denial
S-->>C1: No NOTICE
Sequence diagram for Phase 623 CI evidence verificationsequenceDiagram
participant CI as GitHubActions
participant T as EndToEndTests
participant J as JUnitXML
participant V as TrialInventoryVerifier
participant R as PerRunReceipt
participant A as CIArtifacts
CI->>T: Execute real Ed25519 and loopback socket trials
T->>J: Write 11 executed test cases
CI->>V: verify_phase623_trial.py(JUnitXML, source SHA)
V->>J: Check exact cases and scenario families
J-->>V: No missing, skipped, failed, or unexpected cases
V->>R: Emit source SHA and JUnit SHA-256
CI->>A: Upload JUnit evidence
CI->>A: Upload receipt only on success
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
@codex review Please review exact Phase 623 QEC PR #623 head This PR tests the actual merged #620–#622 security composition through two real loopback IRC socket connections using ephemeral signed UFF experiment evidence (Ed25519) and independently issued test capability grants. Test-only change; no production runtime or protected decoder altered. Executed at this SHA: Phase 623 workflow run 41355448547 SUCCESS. Real Ed25519 sign/verify executed; 11/11 adversarial socket cases passed, 6/6 verifier contract tests passed. Independent JUnit inventory guard confirmed all 8 scenario families, no skips/errors/failures, then emitted a generated SHA-256-bound per-run inventory. Both original JUnit and success-only inventory were uploaded (not committed). Full repository/container workflow 41355448553 still running as of this comment; do not infer success. Focus: adversarial coverage gaps that could produce a protected NOTICE under replay, policy/signer/grant revocation, crossed signed proofs, alternate valid operation identity, compromised trust context, malformed IRC routing, second-client/channel leakage; async socket test false positives; JUnit verifier's completeness checks versus artifact spoofing; accurate receipt/provenance wording. Distinguish real executed observations from inferred claims, and provide minimal reproducible actionable defects only. No claims of durable replay, authenticated human identity, external custody, privileged QEC actions or physical science. Keep exact-head review, full suite, and container CI as separate gates. Do not merge automatically. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c1b1ee5c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…23 JUnit inventory
…vocation dimensions
|
@codex review Please review exact Phase 623 QEC PR #623 head Executed current-head evidence: dedicated Phase 623 run 41356155761: SUCCESS, real Ed25519 sign/verify, 15 verifier contract tests passed, 11 real two-client IRC socket trials passed, JUnit inventory check passed with both per-run artifacts retained. Full Python/container run 41356155675 is a separate check; do not assume it passed while still running. Review only actionable defects, minimal reproduction, expected/actual and executed/inferred. No changes to runtime, historical data or QEC decoder. PR stays unmerged until review and full CI clear; no automatic merge. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Sorry @EmergentMonk, you've used your own review budget of 250,000 diff characters for the last 7 days. You can request another review in 8 hours and 33 minutes by commenting |
Goal
Test the actual integrated network execution path from merged QEC #620 (composed experiment/capability/firewall verification), #621 (real protected IRC command), and #622 (one-use revocation ledger). No producer-controlled ALLOW flags or mocks standing in for real socket effects.
Changes
tests/test_phase623_end_to_end.py: two real loopback IRC clients, real ephemeral Ed25519 signed UFF experiments and issued grants, real verifier-pinned contexts. Wire-observed valid one-shot NOTICE versus replay, independently valid cross-bundle transplant, all four revocation mechanisms, forged signed payload, policy change, wrong-session and channel fanout, saturation, and hash-chain tampering.scripts/maintenance/verify_phase623_trial.py: separately validate JUnit inventory for 11 required executed test cases across 8 scenario families. Reject any skipped, failed, missing or unexpected case and emit per-run content hash/source-SHA receipt. No false stable-digest claim about JUnit timing.tests/test_phase623_receipt_verifier.py: fail-closed test coverage with synthetic XML clearly not represented as executed adversarial evidence..github/workflows/phase623-adversarial.yml: real cryptography backend, actual Ed25519 sign/verify, executed live-socket trials, independent inventory verifier, retained per-run JUnit and success-only receipt artifacts.docs/security/PHASE623_END_TO_END_ADVERSARIAL_TRIAL.md: test matrix and limitations.Protected boundary remains only the non-sensitive
!trusted-observeNOTICE. No production executor or decoder changes, durable authentication, independent custody, quantum hardware, global distributed replay or physical-world proof claimed.Required gates
Draft, do not merge. Need exact-head dedicated CI; full existing Python and container suite; exact-head Codex code and security reviews with no actionable findings. Await actual CI execution before making any passing-claim. Preserve historical artifact bytes and original source/receipt schema.
Summary by Sourcery
Validate the integrated signed IRC observation path through real loopback clients and produce fail-closed, per-run CI evidence for the adversarial trial.
New Features:
Enhancements:
CI:
Documentation:
Tests: