Repository navigation
MAT-010-CLOSURE-001 (Phase A): Formalize Archive Membership - #47
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @EmergentMonk, this pull request is too large to review
It changes 434 files. Sourcery can review pull requests with up to 300 changed files.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ef1b7929d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| files = manifest["files_sha256"] | ||
| observed = {str(p.relative_to(folder)) for p in folder.rglob("*") if p.is_file()} | ||
| require(observed == set(files) | {manifest_path.name}, | ||
| "independent audit file coverage changed") |
There was a problem hiding this comment.
On a fresh checkout, the independent-audit verifier always raises ValueError: independent audit file coverage changed: its manifest requires work/ArchiveModel.olean and work/ArchiveConsumer.olean under each of the three mutation directories, but none of those six files is committed. I confirmed their absence using repository-wide file search and git ls-tree -r for the reviewed commit. Consequently, the documented evidence-verification command and both test_intact_receipts and test_missing_independent_audit_file fail before validating the audit. Commit the required evidence files, or consistently exclude compiled caches from the manifest and update its pinned hash and file count.
Useful? React with 👍 / 👎.
|
@codex Please Review this exact SHA 462858b gainst the existing contract. Report only actionable correctness defects, with a minimal reproduction, expected versus actual behavior, and affected lines. State whether each reproduction was executed or statically inferred. Don’t repeat fixed findings without a new failing case. Keep architectural suggestions separate and non-blocking. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Scope
Formalize the frozen MAT-SPEC-010 direct archive-membership validator (Phase A) over arbitrary finite, exact-string model inputs. This is a focused first PR under the mission's scope-control rule. Parent integrity (Phase B), scientific closure (Phase C), and Python source-to-model refinement remain OPEN.
Frozen source
mat-spec-010-v0.1.0:b8e88a0a32db30558e00704669eeaafee3a8d5f59d12c6a5098f4edba972bb6b1067555d8f48f693; tree646f1de532738feeb59336a427881d643cf32dc1materials/mat_spec_010.pyblob180e44dc81a0ff59cb08bd87d6a87538c275b054; SHA-256e062474d4435e769f8c6c8407bc44ad89cfb2dfa04677b820c3a035d604a90560758a96360726aafbb07abed34620eda178407aeEvidence
2f2ea6d3deffebc7a552ec79f42ea829b9812d3e, receiptformal/sonification/mat010/receipts/proof-002.Falseaxioms ending_cstage1and_cstage2. The initial failed expectation is retained innegative-001; correctednegative-002passed.7e1e415c6590d8bf7257b4cbcd80de58c83d808b: PASS for the scoped model and gate. It freshly replayed the proof and rejected both suffix mutations plus a source-level unsafe suffix definition. Report:formal/sonification/mat010/audit/independent-001/report.json.Limits
REFINEMENT_PROVEDremains OPEN. SHA-256 comparisons do not establish physical source authenticity, collision freedom, archive deposition, or experimental validation. The frozen scientific status remains blocked/open, and no MAT-SPEC-011 is introduced. No production implementation or historical release is changed.Generated execution evidence is marked with
linguist-generatedfor a readable PR diff; original files remain available and hash checked.