Skip to content

test(e2e): people journeys (team access and portal account) - #1163

Open
mortondev wants to merge 7 commits into
test/product-e2e-harnessfrom
test/product-e2e-people-team
Open

mortondev wants to merge 7 commits into
test/product-e2e-harnessfrom
test/product-e2e-people-team

Conversation

@mortondev

@mortondev mortondev commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

End-to-end journeys for People: teammates, invitations, roles and access (PPL-T) and the portal account pages (PPL-ACC). Part 3 of 3 (users and companies: #1156; segments in their own PR).

Covered

  • people/invitations.spec.ts: PPL-T-17 (@smoke); PPL-T-09, T-11, T-13, T-14, T-15, T-18, T-20, T-24, T-25 (@core)
  • people/members.spec.ts (@core): PPL-T-01, T-07, T-33, T-34, T-35 (quarantined), T-37, T-39, T-41, T-42, T-44, T-46 (incl. a non-JSON body answers 400), T-47, T-48 (quarantined), T-50
  • people/roles.spec.ts (@core): PPL-T-53, T-54, T-56, T-58, T-59, T-60, T-61
  • people/portal-account.spec.ts (@core): PPL-ACC-02, ACC-04, ACC-14 (quarantined), ACC-18, ACC-32

Helpers: apps/web/e2e/product/people-team.ts. Every test was broken once to see it go red. Local: 3 runs in a row on a fresh database, --workers=2 --retries=0, all green (quarantined tests excluded).

Quarantined (product bugs, see e2e/QUARANTINE.md)

  • PPL-T-35: choosing Member for a custom/preset role holder keeps the old assignment (principal.service.ts:400 passes no resetAssignment; principal.factory.ts:381 only reconciles when the legacy column moves).
  • PPL-T-48: an owner's personal key can demote or remove the owner over REST (routes/api/v1/principals/$principalId.ts:98, :151 compare with the key's service principal).
  • PPL-ACC-14: saveAvatarKeyFn accepts any avatars/ key, so a person can take (and later delete) someone else's avatar object (functions/user.ts:44, :222).

Not covered in this PR

  • Owner questions (skipped): PPL-T-05, T-06 (UI gated on legacy admin, not member.manage), PPL-ACC-03 (anonymous portal session opens /settings).
  • Open PRs change the outcome: PPL-T-04, T-78 (fix(settings): open each settings page to whom its reads serve #1145), T-71, T-72 (fix(admin): hide Roadmap and Support from roles that cannot open them #1147).
  • Need a workspace-wide plan or seat state (isolated job, not done): PPL-T-16, T-22, T-23, T-38, T-62, T-63, T-64.
  • PPL-ACC-07 (rename from the profile form) was written but left out: under a full parallel run the save intermittently never reaches the server (no toast, name unchanged); passes alone. Cause not found; handed back.
  • Remaining core rows, handed back: PPL-T-69 (lower), T-73, T-75, T-76; PPL-ACC-01, ACC-11, ACC-17, ACC-21, ACC-28, ACC-33, ACC-34, ACC-37, ACC-40, ACC-49 to ACC-52, ACC-55, ACC-56, ACC-65 to ACC-68, ACC-70, ACC-71, ACC-73; every @nightly PPL-T and PPL-ACC row, including the known bugs ACC-42 and ACC-64.

…help center and people

A second Playwright config (playwright.product.config.ts) on the support
suite's harness: same production build, environment, stand-ins and people,
with tests under e2e/tests/<module>/. The setup project turns on Feedback,
Changelog, Help center and Status (and publishes the status page, which the
raw flag write alone does not). Three `@smoke` wiring tests prove every
admin product page and public page opens.

CI gains product-smoke (every PR), product-changes, product-core (four
shards, product paths or the run-product-e2e label, main, nightly),
product-core-report and product-isolated, mirroring the support jobs.
… tests run

The seed's published entries have notified_at NULL, so the changelog
reconciler (armed 25 s after boot) would email them to every subscriber
while tests read Mailpit.
@mortondev mortondev added the run-product-e2e Run the product e2e core suite on this PR label Nov 20, 2026
@mortondev
mortondev force-pushed the test/product-e2e-harness branch from b16d3d9 to aa14deb Compare November 20, 2026 10:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-product-e2e Run the product e2e core suite on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant