Repository navigation
Conversation
mortondev
force-pushed
the
test/product-e2e-harness
branch
from
November 20, 2026 10:20
b16d3d9 to
aa14deb
Compare
mortondev
force-pushed
the
test/product-e2e-people-segments
branch
from
November 20, 2026 10:55
b154441 to
d2b8503
Compare
mortondev
force-pushed
the
test/product-e2e-people-segments
branch
from
November 20, 2026 11:12
d2b8503 to
ba33e6f
Compare
mortondev
force-pushed
the
test/product-e2e-people-segments
branch
from
November 20, 2026 11:37
ba33e6f to
b727d93
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End-to-end journeys for People: segments (PPL-G), part 2 of 3. Users and companies are in #1156. Team access and portal account pages follow in their own PR.
Covered
people/segments.spec.ts@core: PPL-G-01, G-03, G-05, G-06, G-07, G-08, G-17, G-20, G-21, G-22, G-25, G-27, G-28, G-30, G-44@nightly: PPL-G-02, G-09, G-11, G-12, G-13, G-19, G-23, G-31, G-45people/segment-access.spec.ts: PPL-G-34 (@smoke), G-35, G-36 (@core), G-38 (@core@isolated, private portal with allowed segments)people/segments.serial.spec.ts: PPL-G-50 (@nightly, quarantined)Helpers:
apps/web/e2e/product/people-segments.ts.Harness change (small, additive)
src/lib/server/e2e-harness/sweeps.ts) gainssegment-evaluation: one pass of the queue, running every dynamic segment the scheduler would schedule now through the queue's own handler (runSegmentEvaluation). It returns{ evaluated, failed }. There is a unit test in__tests__/sweeps.test.ts, and theSweepNameunion ine2e/support/sweeps.tsgains the name. PPL-G-12 uses it.Lower rows
The existing unit tests already cover these, so no new test was added:
segment-scheduler.test.tssegment-membership.test.ts(the priority matrix)segment-gate.test.tsandaccess.test.ts(the empty list on either side)segment-attribute-values.test.tsQuarantined (product bugs, see
e2e/QUARANTINE.md)vote_countandcomment_countrules query the tablesvotesandcomments, which do not exist (segment.evaluation.ts:154/156/275/281). Every such evaluation fails with a 500. The seeded "Active Users" segment can never be evaluated.evaluateAllSegmentsFnreturns a 500 in every seeded workspace. It stops at the first failing segment (segment.evaluation.ts:469), and the bug above makes "Active Users" fail.removed($slug.members.ts:153).$slug.members.ts:71,:124).addedon every run (segment.evaluation.ts:431).CRON_REGEXaccepts patterns thatparseCronrejects, so the segment never auto-evaluates (functions/admin.ts:1186).updateSegmentacceptsrules: nullon a dynamic segment, and the next evaluation empties it (segment.service.ts:217).Skipped
segment.manage.segment.viewholders.Local runs
On a fresh DB,
--workers=2 --retries=0, three runs in a row:segments.spec.ts+segment-access.spec.ts: 28 passed each time.@isolatedG-38, one worker: 3/3 passed.Each passing test was broken once and went red.