Skip to content

test(e2e): status page journeys (admin) - #1172

Open
mortondev wants to merge 4 commits into
mainfrom
test/product-e2e-status
Open

mortondev wants to merge 4 commits into
mainfrom
test/product-e2e-status

Conversation

@mortondev

@mortondev mortondev commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Status page product e2e journeys, part 1 of 3 (admin). Base: #1150 (test/product-e2e-harness). #1186 and #1201 stack on this.

Covered (ids per spec file and tier)

Spec @smoke @core @nightly @quarantine
admin-incidents.spec.ts A-17, A-21 A-10, A-18, A-19, A-20, A-22, A-23, A-24, A-26, A-28, A-29, A-31 A-25, A-27, A-32, A-33 (deleted id) A-30, A-33 (malformed id)
admin-maintenance.spec.ts A-34 A-35/A-36, A-38, A-39, A-40, A-43, A-45 A-37, A-42, A-44 A-46
admin-access.spec.ts A-01, A-02, A-03 A-05
admin-services.spec.ts A-06, A-09, A-11 A-07, A-08, A-12, A-13, A-14
admin-templates.spec.ts A-48 A-47 A-49
admin-subscribers.spec.ts A-51, A-52 A-50, A-54, A-55 A-53
admin-overview.spec.ts A-56
admin-overview.serial.spec.ts (product-serial) A-57

Helpers: e2e/product/status.ts. Incidents made by helpers default to notifySubscribers: false (a publish mails every subscriber in the workspace).

Harness additions (small, additive):

  • status-maintenance and status-notify sweep entries (src/lib/server/e2e-harness/sweeps.ts, wall clock only; tests backdate their own window) with a unit test; names added to e2e/support/sweeps.ts.
  • e2e/product/setup.product.ts: after its writes, bust the settings cache until /status answers 200. A request that read the settings row mid-setup could put the old row back in the shared cache after the bust; on a loaded machine whole runs then saw "Status page not found". Other areas share this file.

Quarantined (product bugs, see e2e/QUARANTINE.md)

  • A-30: status.service.ts:242 defaults notifySubscribers to true for a non-backfill incident created already resolved (also S-23).
  • A-33 malformed id: findStatusIncidentById (status.service.ts:866) throws on a malformed TypeID; editor shows "Couldn't load this incident".
  • A-46: maintenance with no dates accepted (status.service.ts:183).
  • A-49: template name refused as "Title is required" (status.service.ts:1161, :1191).
  • A-53: subscriber list pages on created_at only (status.subscription.ts:210, :236): 35 imported, 30 listed.
  • A-57: overview "Visitors currently see" derives from every service incl. gated (functions/status.ts:624).

Other findings (not quarantined)

  • Race: listStatusIncidents (status.service.ts:936) lists ids then loads each with getStatusIncidentById, which throws when another request deletes one in between, so the whole overview call fails with STATUS_INCIDENT_NOT_FOUND. Seen in a parallel run; A-56 retries the read.
  • Suspected UI bug: in the incident editor's sidebar, a pointer click on an affected-service row near the bottom was intercepted by the modal footer for 60 s on every fresh database (Playwright: footer "subtree intercepts pointer events"). Tests tick services from the keyboard.

Owner questions (skipped)

  • A-29 future-dated backfill is accepted (UI caps at now): should the server refuse it?

Local runs

Fresh database, --workers=2 --retries=0, whole tests/status/ folder three times in a row: all green (93 passed per run on the final stack; serial and isolated specs run separately, green 3x). CI on this PR: product-smoke, product-core (4 shards) and product-isolated green, zero flaky.

@mortondev mortondev added the run-product-e2e Run the product e2e core suite on this PR label Nov 20, 2026
@mortondev
mortondev force-pushed the test/product-e2e-harness branch from b16d3d9 to aa14deb Compare November 20, 2026 10:20
@mortondev
mortondev changed the base branch from test/product-e2e-harness to main November 20, 2026 11:06
@mortondev
mortondev added this pull request to stack #1204 November 20, 2026 11:06
@mortondev
mortondev removed this pull request from stack #1204 November 20, 2026 11:08
@mortondev
mortondev changed the base branch from main to test/product-e2e-harness November 20, 2026 11:08
@mortondev
mortondev changed the base branch from test/product-e2e-harness to main November 20, 2026 11:34
@mortondev
mortondev force-pushed the test/product-e2e-status branch 2 times, most recently from 311495e to 3a3f1c4 Compare November 20, 2026 11:46
@mortondev
mortondev force-pushed the test/product-e2e-status branch from 3a3f1c4 to 0dce20e Compare November 20, 2026 12:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-product-e2e Run the product e2e core suite on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant