Repository navigation
Conversation
mortondev
force-pushed
the
test/product-e2e-harness
branch
from
November 20, 2026 10:20
b16d3d9 to
aa14deb
Compare
mortondev
force-pushed
the
test/product-e2e-status
branch
2 times, most recently
from
November 20, 2026 11:46
311495e to
3a3f1c4
Compare
mortondev
force-pushed
the
test/product-e2e-status
branch
from
November 20, 2026 12:04
3a3f1c4 to
0dce20e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status page product e2e journeys, part 1 of 3 (admin). Base: #1150 (
test/product-e2e-harness). #1186 and #1201 stack on this.Covered (ids per spec file and tier)
@smoke@core@nightly@quarantineadmin-incidents.spec.tsadmin-maintenance.spec.tsadmin-access.spec.tsadmin-services.spec.tsadmin-templates.spec.tsadmin-subscribers.spec.tsadmin-overview.spec.tsadmin-overview.serial.spec.ts(product-serial)Helpers:
e2e/product/status.ts. Incidents made by helpers default tonotifySubscribers: false(a publish mails every subscriber in the workspace).Harness additions (small, additive):
status-maintenanceandstatus-notifysweep entries (src/lib/server/e2e-harness/sweeps.ts, wall clock only; tests backdate their own window) with a unit test; names added toe2e/support/sweeps.ts.e2e/product/setup.product.ts: after its writes, bust the settings cache until/statusanswers 200. A request that read the settings row mid-setup could put the old row back in the shared cache after the bust; on a loaded machine whole runs then saw "Status page not found". Other areas share this file.Quarantined (product bugs, see
e2e/QUARANTINE.md)status.service.ts:242defaultsnotifySubscribersto true for a non-backfill incident created already resolved (also S-23).findStatusIncidentById(status.service.ts:866) throws on a malformed TypeID; editor shows "Couldn't load this incident".status.service.ts:183).status.service.ts:1161,:1191).created_atonly (status.subscription.ts:210,:236): 35 imported, 30 listed.functions/status.ts:624).Other findings (not quarantined)
listStatusIncidents(status.service.ts:936) lists ids then loads each withgetStatusIncidentById, which throws when another request deletes one in between, so the whole overview call fails with STATUS_INCIDENT_NOT_FOUND. Seen in a parallel run; A-56 retries the read.Owner questions (skipped)
Local runs
Fresh database,
--workers=2 --retries=0, wholetests/status/folder three times in a row: all green (93 passed per run on the final stack; serial and isolated specs run separately, green 3x). CI on this PR: product-smoke, product-core (4 shards) and product-isolated green, zero flaky.