Repository navigation
Conversation
mortondev
force-pushed
the
test/product-e2e-harness
branch
from
November 20, 2026 10:20
b16d3d9 to
aa14deb
Compare
mortondev
force-pushed
the
test/product-e2e-feedback-admin
branch
3 times, most recently
from
November 20, 2026 11:35
985259d to
5d0250d
Compare
…ts status from the post modal
…ith six product bugs quarantined
…ged, facet and updatedBefore
mortondev
force-pushed
the
test/product-e2e-feedback-admin
branch
from
November 20, 2026 11:52
5d0250d to
b1baa4a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product suite e2e tests for the team side of feedback: the inbox (FBA-I) and post management (FBA-P). Part 1 of 3 for the FBA area; parts 2 (merge, moderation, settings) and 3 (AI, notifications, import/export) follow as their own PRs.
Also carries the shared base commit:
e2e/product/feedback-admin.ts(seeding helpers) and two sweep runner entries,summary-sweepandmerge-sweep(src/lib/server/e2e-harness/sweeps.ts, wall clock only, unit tested).Inbox:
feedback/admin-inbox.spec.ts@smoke: FBA-I-01@core: FBA-I-02, I-04, I-05, I-06, I-08, I-11 (quarantined), I-12 (quarantined), I-14, I-15, I-16, I-17, I-20, I-24, I-26@nightly: FBA-I-03 (@isolated), I-07, I-09, I-10, I-13, I-18, I-21, I-25, I-27 (quarantined), I-28, I-30, I-32 (quarantined)updatedBefore) added topost.inbox.db.test.ts. I-19 is already proven bypost.search.test.ts(canWidenSearch, operators never probed).resolveFeatureFlagsinsettings.types.tsforcesfeedback: trueat read time), so the test proves a storedfeedback:falseis repaired and the inbox and settings pages stay open.Quarantined (product bugs, see
e2e/QUARANTINE.md)teamResponseExistsSql,apps/web/src/lib/server/domains/posts/post.inbox.ts:43, matches any team comment. Fix: also requireis_private = false.feedback-table-view.tsx:244) and is skipped wheninbox-container.tsx:85returnsundefinedfor an empty counts map. Fix: filter on the server, or treat a missing map as "none".deleteView,apps/web/src/lib/server/domains/post-views/post-views.service.ts:76, updates by id only. Fix: scope the update to the creator (or a shared view for admins) and refuse when nothing matched.routes/admin/feedback.index.tsx:71) only resets the error boundary, so the failed loader never re-runs and the alert stays. Fix:router.invalidate()beforereset().Local runs
Each test was mutation checked (an expectation flipped, seen red, restored).
admin-inbox.spec.ts, fresh DB, 3 runs at--workers=2 --retries=0: 23 passed each run. The 4 quarantined tests failed each run on the bug's own assertion. 1@isolatedtest was skipped, and passed once on its own withE2E_SUPPORT_ISOLATED=1 --workers=1.post.inbox.db.test.ts: 5/5 passed, and the new cases go red when mutated.Post actions, comments and votes (FBA-P)
admin-post-actions.spec.ts:@smokeP-01, P-07; 13@core; 8@nightly. Quarantined: P-04 (@isolated, default status ignored), P-08 (repeat status re-notifies), P-11 (non-team owner accepted), P-17 (new:post.deletedfrom the admin delete has no deletedBy), P-21 (deleted canonical orphans duplicates).admin-post-comments.spec.ts: 5@core, 2@nightly. Quarantined: P-30 (status change through a comment without post.set_status).admin-votes.spec.ts: 3@core, 2@nightly.post-service.test.ts.updateStatusFn({ id, isDefault: true })on its own returns a 500, becausestatus.service.tsupdateStatusruns an empty.set({}), and only after the default has already moved.--workers=2 --retries=0, stable after the timing fixes. The quarantined tests went red as expected, and every other test was mutation checked.