Skip to content

test(e2e): feedback admin journeys (inbox and posts) - #1180

Open
mortondev wants to merge 6 commits into
mainfrom
test/product-e2e-feedback-admin
Open

mortondev wants to merge 6 commits into
mainfrom
test/product-e2e-feedback-admin

Conversation

@mortondev

@mortondev mortondev commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Product suite e2e tests for the team side of feedback: the inbox (FBA-I) and post management (FBA-P). Part 1 of 3 for the FBA area; parts 2 (merge, moderation, settings) and 3 (AI, notifications, import/export) follow as their own PRs.

Also carries the shared base commit: e2e/product/feedback-admin.ts (seeding helpers) and two sweep runner entries, summary-sweep and merge-sweep (src/lib/server/e2e-harness/sweeps.ts, wall clock only, unit tested).

Inbox: feedback/admin-inbox.spec.ts

  • @smoke: FBA-I-01
  • @core: FBA-I-02, I-04, I-05, I-06, I-08, I-11 (quarantined), I-12 (quarantined), I-14, I-15, I-16, I-17, I-20, I-24, I-26
  • @nightly: FBA-I-03 (@isolated), I-07, I-09, I-10, I-13, I-18, I-21, I-25, I-27 (quarantined), I-28, I-30, I-32 (quarantined)
  • Lower rows: I-22 (merged post out of list, facet and board counts until unmerged), I-29 (real-DB disjunctive facet counts) and I-31 (updatedBefore) added to post.inbox.db.test.ts. I-19 is already proven by post.search.test.ts (canWidenSearch, operators never probed).
  • Not here: I-23 (moderation spec, part 2); I-33 skipped (owner question: should the Contributor preset read boards without board.manage?).
  • I-03 deviation: the Feedback product can no longer be switched off (resolveFeatureFlags in settings.types.ts forces feedback: true at read time), so the test proves a stored feedback:false is repaired and the inbox and settings pages stay open.

Quarantined (product bugs, see e2e/QUARANTINE.md)

  • FBA-I-11: the Team response filter counts a private internal note as a response. teamResponseExistsSql, apps/web/src/lib/server/domains/posts/post.inbox.ts:43, matches any team comment. Fix: also require is_private = false.
  • FBA-I-12: Has duplicates shows every post when no loaded post has a pending suggestion. The filter runs in the browser (feedback-table-view.tsx:244) and is skipped when inbox-container.tsx:85 returns undefined for an empty counts map. Fix: filter on the server, or treat a missing map as "none".
  • FBA-I-27: any post.edit holder can delete any saved view by id, including a colleague's private view they cannot list. deleteView, apps/web/src/lib/server/domains/post-views/post-views.service.ts:76, updates by id only. Fix: scope the update to the creator (or a shared view for admins) and refuse when nothing matched.
  • FBA-I-32 (new): the inbox error state's Try again (routes/admin/feedback.index.tsx:71) only resets the error boundary, so the failed loader never re-runs and the alert stays. Fix: router.invalidate() before reset().

Local runs

Each test was mutation checked (an expectation flipped, seen red, restored).

  • admin-inbox.spec.ts, fresh DB, 3 runs at --workers=2 --retries=0: 23 passed each run. The 4 quarantined tests failed each run on the bug's own assertion. 1 @isolated test was skipped, and passed once on its own with E2E_SUPPORT_ISOLATED=1 --workers=1.
  • post.inbox.db.test.ts: 5/5 passed, and the new cases go red when mutated.

Post actions, comments and votes (FBA-P)

  • admin-post-actions.spec.ts: @smoke P-01, P-07; 13 @core; 8 @nightly. Quarantined: P-04 (@isolated, default status ignored), P-08 (repeat status re-notifies), P-11 (non-team owner accepted), P-17 (new: post.deleted from the admin delete has no deletedBy), P-21 (deleted canonical orphans duplicates).
  • admin-post-comments.spec.ts: 5 @core, 2 @nightly. Quarantined: P-30 (status change through a comment without post.set_status).
  • admin-votes.spec.ts: 3 @core, 2 @nightly.
  • Lower rows P-03/06/10/24/31 are covered at the server-function boundary (the named unit files mock the DB). P-16 is already proven by post-service.test.ts.
  • Also found (not quarantined): updateStatusFn({ id, isDefault: true }) on its own returns a 500, because status.service.ts updateStatus runs an empty .set({}), and only after the default has already moved.
  • Local runs: 3 runs on a fresh DB at --workers=2 --retries=0, stable after the timing fixes. The quarantined tests went red as expected, and every other test was mutation checked.

@mortondev mortondev added the run-product-e2e Run the product e2e core suite on this PR label Nov 20, 2026
@mortondev
mortondev force-pushed the test/product-e2e-harness branch from b16d3d9 to aa14deb Compare November 20, 2026 10:20
@mortondev
mortondev changed the base branch from test/product-e2e-harness to main November 20, 2026 11:05
@mortondev
mortondev force-pushed the test/product-e2e-feedback-admin branch 3 times, most recently from 985259d to 5d0250d Compare November 20, 2026 11:35
@mortondev
mortondev force-pushed the test/product-e2e-feedback-admin branch from 5d0250d to b1baa4a Compare November 20, 2026 11:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-product-e2e Run the product e2e core suite on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant