Skip to content

cold-wallet: bump build to 1.2.0+18 - #678

Merged
illuzen merged 1 commit into
mainfrom
bump-cold-wallet-build-18
Oct 1, 2026
Merged

illuzen merged 1 commit into
mainfrom
bump-cold-wallet-build-18

Conversation

@illuzen

@illuzen illuzen commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

The APK release workflow tags cold-wallet-v<pubspec version> and refuses an existing tag; cold-wallet-v1.2.0+17 was already released before #677 merged, so the build for the NEAR cold signing release failed at the tagging step.

Bumps cold-wallet-app/pubspec.yaml to 1.2.0+18. Nothing else changes.

@illuzen illuzen added the bot-review Request automated review from review-bot label Oct 1, 2026
@illuzen
illuzen merged commit 4466986 into main Oct 1, 2026
3 checks passed

@n13 n13 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT-6 Sol

Verdict: COMMENT (retrospective approval). The PR merged during review; I found no blocking issues in the version bump.

cold-wallet-app/pubspec.yaml:5 changes only the cold wallet version from 1.2.0+17 to 1.2.0+18. The APK workflow reads that value and constructs cold-wallet-v1.2.0+18; the previous +17 tag exists on the remote, while the new tag is available.

Validation: inspected the complete base-to-head diff and release workflow; git diff --check passed; confirmed the workflow-extracted version and remote tag availability. No Flutter build or tests were run for this metadata-only change. The Analyze CI check was still in progress at review time.

@n13 n13 removed the bot-review Request automated review from review-bot label Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants