Repository navigation
cold-wallet: bump build to 1.2.0+18 - #678
Merged
Merged
Conversation
n13
reviewed
Oct 1, 2026
n13
left a comment
Collaborator
There was a problem hiding this comment.
Reviewer model: GPT-6 Sol
Verdict: COMMENT (retrospective approval). The PR merged during review; I found no blocking issues in the version bump.
cold-wallet-app/pubspec.yaml:5 changes only the cold wallet version from 1.2.0+17 to 1.2.0+18. The APK workflow reads that value and constructs cold-wallet-v1.2.0+18; the previous +17 tag exists on the remote, while the new tag is available.
Validation: inspected the complete base-to-head diff and release workflow; git diff --check passed; confirmed the workflow-extracted version and remote tag availability. No Flutter build or tests were run for this metadata-only change. The Analyze CI check was still in progress at review time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The APK release workflow tags
cold-wallet-v<pubspec version>and refuses an existing tag;cold-wallet-v1.2.0+17was already released before #677 merged, so the build for the NEAR cold signing release failed at the tagging step.Bumps
cold-wallet-app/pubspec.yamlto1.2.0+18. Nothing else changes.