Skip to content

ui(dialogs): make destructive query and DML preview dialogs adaptive and prevent table name overflow #1642

Closed

Description

@ZhuchkaTriplesix

Problem

  1. Non-adaptive dialog constraints:
    In lib/features/workspace/destructive_query_dialog.dart, the dialog card uses hardcoded fixed constraints:

    constraints: const material.BoxConstraints(
      minWidth: 540,
      maxWidth: 680,
      minHeight: 440,
      maxHeight: 580,
    ),
    child: material.FocusTraversalGroup(
      child: material.SizedBox(height: 540, ...),

    It does not use WindowLayout.dialogConstraints(context) or WindowLayout.dialogSymmetricInsets(context). When running on compact window widths (e.g. 520px) or with a UI scale of 1.25x+, the dialog overflows screen bounds.

  2. Unconstrained table name in DML Preview:
    In lib/features/workspace/dml_preview_dialog.dart, the header row displays Text('${widget.plan.schema}.${widget.plan.tableName}') without Flexible and without overflow: TextOverflow.ellipsis. For long table names, it causes horizontal RenderFlex overflow.

Change

  • Migrate destructive_query_dialog.dart to use WindowLayout.dialogConstraints(context) and WindowLayout.dialogSymmetricInsets(context).
  • Wrap the table name in dml_preview_dialog.dart with Flexible(child: Text(..., overflow: TextOverflow.ellipsis)).

Activity

  1. ZhuchkaTriplesix commented on Oct 25, 2026

    @ZhuchkaTriplesix
    MemberAuthor

    Fixed on dev by 82baa5e: fix(ui): destructive-query dialog fits small windows; long table names in DML preview are cut (#1642) (#1698). It reaches main with the next dev to main merge (closed after checking the code and its tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingfrontendTheme parser epic label: frontend

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions