Repository navigation
fix(connections): editing a connection of a missing extension or driver explains why nothing opens (#1314) - #1327
Merged
Conversation
…er explains why nothing opens (#1314) promptEditConnection returned null without a word when the extension was not installed, and fell back to the first driver of a manifest when none matched the connection's type, opening another driver's form. - A missing extension, a driver the extension no longer provides, and an unknown connection type each show a toast saying what is missing. - The driver is the one of the row's type, or the only one the extension has; never another of several.
github-actions
Bot
added
bug
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1314
Problem (
promptEditConnection,connection_creation_flow.dart)nulland nothing happened._driverForConnectionfell back to the first driver of the manifest when none matched the row's type, so an extension with several drivers opened the wrong driver's form and saving could change the connection's meaning.nulltoo.Fix
driverForConnection: the driver whose id is the row's type; the only driver when the extension has exactly one (rows saved with another type string keep working); otherwise none.Tests (
edit_extension_connection_test.dart): the driver choice (type match, case-insensitive, single driver, never one of several); the toast for a missing extension names it and says not installed or is disabled; the toast for an unknown type.