Repository navigation
perf(ui): eliminate per-frame ImageFilter.blur sigma animation in showAppDialog backdrop - #1429
Merged
Merged
Conversation
…wAppDialog backdrop
github-actions
Bot
added
frontend
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1341
Summary of Changes
showAppDialog's_DialogBackdrop, previouslysigmaX: sigma * tandsigmaY: sigma * twere animated linearly over 24 frames during enter and exit. This forced Skia / Impeller rasterizers to rebuild and execute Gaussian blur shader pipelines on every single frame, causing raster spikes up to 18 ms.ImageFilter.blur(sigmaX: sigma, sigmaY: sigma)whenevert > 0while smoothly fading the backdrop tint alphaColor(0xFF000000).withValues(alpha: tintAlpha * t).test/shared/app_dialog_test.dartto test constant blur sigma and fading tint alpha during transitions.