Repository navigation
fix(workspace): a long query error scrolls instead of overflowing the results pane - #1436
Merged
Merged
Conversation
… results pane The error column gave the message unbounded height, so a long driver error pushed the column past the pane (BOTTOM OVERFLOWED). The message now sits in a Flexible and scrolls in the space that is left; a test covers a 40-line error in a 300 px pane.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while driving a build of `dev`: a long SQLite error showed BOTTOM OVERFLOWED BY 77 PIXELS.
Change
The error column in `ResultsTab` gave `VirtualSelectableTextView` unbounded height. The column is now `MainAxisSize.min` and the message sits in a `Flexible`, so it scrolls in the space that is left.
Tests
`results_tab_test`: a 40-line error in a 600x300 pane has no exception and stays inside the pane.
Not run locally; CI is the check.