Repository navigation
fix(editor): prevent duplicate onChanged, cursor false positives, and enable default highlighting (#1430) - #1446
Merged
Conversation
… enable default highlighting (#1430)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1430
Changes
onChangedinvocations:onChanged: widget.onChangedfrom inner Material and ShadcnTextFields to avoid firing twice per keystroke alongside_effectiveControllerlistener.onChangedon cursor / selection changes:_lastTexttracking in_QueryaCodeEditorState._onTextChangedcomparescurrentText == _lastTextand skips firing when only selection/cursor changed.widget.controller == nullandwidget.enableHighlighting == true, initialize_internalControllerusingSyntaxHighlightService.createHighlightControllerso SQL/JSON syntax highlighting works out of the box.didUpdateWidget:_internalControllerwhenlanguageorenableHighlightingchanges, preserving current text and selection.test/core/editor/querya_code_editor_test.dartvalidating:onChangedcall per typed character edit.onChangedcalls on cursor clicks and selection changes.QueryaHighlightControllerby default whenenableHighlightingis true.TextEditingControllerwhenenableHighlightingis false.languagechange.