Skip to content

fix(grid): eliminate redundant debounce timer and duplicate validation in DataGridValuePanel (#1431) - #1449

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1431-datagrid-value-panel-timer
Oct 11, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1431-datagrid-value-panel-timer

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Closes #1431

Changes

  1. Suppress debounce timers during programmatic text updates:
    • Added _isProgrammaticUpdate flag and helper _setControllerTextProgrammatically.
    • In didUpdateWidget, setting cellValue updates the controller without triggering the 150 ms debounce timer.
    • Synchronous validation runs once without being followed 150 ms later by a duplicate validation callback.
  2. Handle Format / Minify cleanly:
    • _formatCode() and _minifyCode() now use _setControllerTextProgrammatically and invoke validation immediately rather than waiting on an unnecessary debounce delay.
  3. Unit tests:
    • Added test in test/features/workspace/data_grid_value_panel_test.dart verifying immediate synchronous validation on didUpdateWidget and absence of scheduled timers.

@github-actions github-actions Bot added bug Something isn't working performance Theme parser epic label: performance data-grid Interactive data grid, cell editor, filtering, groupings P2 Medium priority / Parity & Refactoring labels Oct 11, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 00d325c into dev Oct 11, 2026
13 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1431-datagrid-value-panel-timer branch October 11, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working data-grid Interactive data grid, cell editor, filtering, groupings P2 Medium priority / Parity & Refactoring performance Theme parser epic label: performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant