Repository navigation
fix(ui): align Preferences button labels, icons and Close variant - #1452
Merged
Merged
Conversation
Close in the Preferences footer is a dismiss action, not a state change, so it is secondary instead of primary. About & Storage labels use sentence case like the rest of the app, and the Extensions buttons get the same icons as their About counterparts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during the visual button-consistency review of the current dev build.
Closeis secondary: it only dismisses the dialog, primary is reserved for state-changing actions.Open app data folder,GitHub repository, ...), matching the rest of the app and the Extensions/Appearance sections.Install from file…andOpen extensions folderget icons, like the same actions elsewhere in Preferences.Refs #1331