Repository navigation
fix(ui): the dropdown menu is at least as wide as its trigger - #1456
Merged
Merged
Conversation
The trigger is measured when the menu opens and becomes the menu's minimum width, so the open menu lines up with the field. Refs #1444
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1444.
The menu of
QueryaDropdownwas as wide as its longest item (Preferences, Theme mode: trigger ~360 px, menu ~185 px). The trigger is now keyed and measured on open, and its width is the menu's minimum width; the maximum is still bounded by the viewport.Test: a 320 px dropdown with short items opens a menu that is at least 320 px wide.