Repository navigation
perf(editor): eliminate syntax highlight flicker on documents >= 8KB (#1351) - #1458
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1351
Problem
In
QueryaHighlightController, when editing documents wheretext.length >= kSyntaxHighlightIsolateThreshold(8192 characters / ~200 lines):buildTextSpanpreviously saw_cachedText == textas false and fell back to plain monochrome text (TextSpan(style: style, text: text)).kSyntaxHighlightDebounce(100 ms) did the worker isolate complete and callnotifyListeners().Solution
patchHighlightSegmentsinsyntax_highlight_isolate.dart, which patches cached segments across untouched prefix and suffix ranges while inserting the edited region with zero latency.QueryaHighlightControllerinstead of dropping to monochrome plain text.patchHighlightSegmentsand verified that syntax styling is retained during live typing in large documents.