Skip to content

fix(ui): dismiss-only dialogs use a ghost Close in QueryaDialogActions #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Oct 11, 2026
Merged

fix(ui): dismiss-only dialogs use a ghost Close in QueryaDialogActions #1460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions lib/features/connections/driver_manager_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,24 +127,11 @@ class _DriverManagerDialogContent extends material.StatelessWidget {
),
),
),
material.Container(
padding: const material.EdgeInsets.symmetric(
horizontal: 24, vertical: 16),
decoration: material.BoxDecoration(
border: material.Border(
top: material.BorderSide(
color: theme.border.withValues(alpha: 0.3)),
),
),
child: material.Row(
mainAxisAlignment: material.MainAxisAlignment.end,
children: [
QueryaButton.primary(
label: 'Close',
onPressed: () => material.Navigator.of(context).pop(),
size: QueryaControlSize.lg,
),
],
QueryaDialogActions(
cancel: QueryaButton.ghost(
label: 'Close',
onPressed: () => material.Navigator.of(context).pop(),
size: QueryaControlSize.lg,
),
),
],
Expand Down
2 changes: 1 addition & 1 deletion lib/features/extensions/presentation/pages/extension_manager_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ class _ExtensionManagerContentState
),
),
const material.SizedBox(width: 16),
QueryaButton.primary(
QueryaButton.ghost(
label: 'Close',
onPressed: () => material.Navigator.of(context).pop(),
size: QueryaControlSize.lg,
Expand Down
26 changes: 5 additions & 21 deletions lib/features/help/about_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,27 +80,11 @@ class _AboutDialogContentState extends material.State<_AboutDialogContent> {
],
),
),
material.Container(
padding: const material.EdgeInsets.symmetric(
horizontal: 24,
vertical: 16,
),
decoration: material.BoxDecoration(
border: material.Border(
top: material.BorderSide(
color: theme.border.withValues(alpha: 0.3),
),
),
),
child: material.Row(
mainAxisAlignment: material.MainAxisAlignment.end,
children: [
QueryaButton.primary(
label: 'Close',
onPressed: () => material.Navigator.of(context).pop(),
size: QueryaControlSize.lg,
),
],
QueryaDialogActions(
cancel: QueryaButton.ghost(
label: 'Close',
onPressed: () => material.Navigator.of(context).pop(),
size: QueryaControlSize.lg,
),
),
],
Expand Down
31 changes: 7 additions & 24 deletions lib/features/settings/preferences_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,31 +409,14 @@ class PreferencesDialogContentState
),

// Footer Actions
material.Container(
padding: const material.EdgeInsets.symmetric(
horizontal: 20,
vertical: 12,
),
decoration: material.BoxDecoration(
border: material.Border(
top: material.BorderSide(
color: theme.border.withValues(alpha: 0.28),
),
),
QueryaDialogActions(
leading: const PreferencesHint(
'Changes apply immediately and persist locally.',
),
child: material.Row(
children: [
const material.Expanded(
child: PreferencesHint(
'Changes apply immediately and persist locally.',
),
),
QueryaButton.secondary(
label: 'Close',
onPressed: () => material.Navigator.of(context).pop(),
size: QueryaControlSize.lg,
),
],
cancel: QueryaButton.ghost(
label: 'Close',
onPressed: () => material.Navigator.of(context).pop(),
size: QueryaControlSize.lg,
),
),
],
Expand Down
2 changes: 1 addition & 1 deletion lib/features/updater/update_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ class UpdateDialogContentState extends material.State<UpdateDialogContent> {
),
],
UpdateDialogPhase.upToDate => [
QueryaButton.primary(
QueryaButton.ghost(
label: 'Close',
onPressed: () => material.Navigator.of(context).pop(),
size: QueryaControlSize.lg,
Expand Down
Loading