Repository navigation
refactor(ui): connection forms use QueryaDialogActions for their footer - #1463
Merged
Merged
Conversation
PostgreSQL, MySQL, SQLite, Redis, MongoDB and extension connection forms build Test connection + Cancel + Save by hand. They now use QueryaDialogActions: Cancel, Test connection, Save in the standard order, spacing 8, one divider, Esc cancels. Refs #1441
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1441.
The six connection forms (PostgreSQL, MySQL, SQLite, Redis, MongoDB, extension) assembled Test connection, Cancel and Save by hand: some with a
Wrap, some with aRowandSpacer, 12 px gaps, some without the divider. They now useQueryaDialogActionswith the standard order (Cancel, Test connection, Save), spacing 8, one divider and Esc to cancel; the enabled state of the actions still comes from the form validity notifier.Behaviour change to check: Test connection moves from the left edge to the right group, next to Cancel and Save, as the standard orders the footer. The old
Wrapallowed the footer to wrap on a very narrow viewport; the kit footer is a single row, which is fine at the dialog's minimum width but worth a look at an extreme window size.