Repository navigation
fix(windows): make the Open with registration an optional installer task (#1595) - #1596
Merged
Merged
Conversation
The Applications\querya_desktop.exe keys were always written, so Querya appeared in the Open with menu without the user asking for it. They are now behind a new unchecked 'openwith' task next to the .sql and SQLite association tasks. Closes #1595
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Inno Setup installer always registered
Applications\querya_desktop.exe, so Querya appeared in the "Open with" menu unasked. It is now a separate, unchecked task (openwith) in the "File associations" group, like the.sqland SQLite associations.Existing installs keep the keys until uninstall. The script was not compiled locally (no ISCC on Linux); it needs a CI or Windows build to confirm.
Closes #1595