Repository navigation
feat(ext-tester): --strict and the action's strict input (#1487) - #1621
Merged
Merged
Conversation
…put for the action (#1487) A missing OS sandbox is only a warning, so --sandbox could pass green without isolating anything. --strict turns warnings into exit code 1.
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1487 (quality of the extension-author CI).
Found while hardening
QueryaHub/extension-template: on a GitHub runner the OS sandbox was silently missing, the tester printedWARN launchand the run was green, so--sandboxtested nothing. Warnings never fail the tester.querya-ext-tester --strict: a warning makes the exit code 1 (HarnessReport.passes(strict:);isSuccessis unchanged, so JUnit/TAP and everything else behave as before)..github/actions/test-extension:strictinput, defaultfalse.extension-testing.md) and CHANGELOG; unit test for the strict rule.Not in a release yet, so the template cannot use
strict: trueuntil the next release publishes a tester with the flag; it keeps its JUnit grep until then. Not run locally, CI decides.