Repository navigation
fix(storage): the legacy profile migration puts querya.db in last and whole (#1766) - #1787
Merged
Merged
Conversation
… whole, so an interrupted copy is retried (#1766)
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1766.
The migration is skipped once
querya_desktop/querya.dbexists, so an interrupted copy must never leave that file behind. Now every other file (including-wal/-shm) is copied first, and the database is copied under a temporary name and renamed into place. The legacy directory is not touched.Not done: the issue's alternative of staging the whole tree in a sibling directory; the support directory already exists at this point, so it could not be renamed over it. Test: a copy that fails midway leaves no
querya.db, and the next call migrates again. Not run locally, CI will.