Repository navigation
fix(platform): small robustness gaps in openDirectoryInFileManager and the Mongo TLS temp key (#1768) - #1789
Merged
Merged
Conversation
…t create the directory; the Mongo TLS temp key is 0600 before it is written and a running instance's temp directory is kept (#1768)
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1768.
openDirectoryInFileManagerreturnsfalsewhen creating the directory fails, as its contract says.resolveMongoTlsCertificateKeyFile: the file is created empty andchmod 600before the key is written; any failure removes the temp directory (it was left behind when the write threw).querya_mongo_tls_<pid>_...;cleanupStaleMongoTlsTempFileskeeps the directories of processes that are still running (kill -0/tasklist), so a second instance's start no longer deletes the first one's certificate file. Directories without a pid (older versions) and ones of dead processes are removed as before.