Repository navigation
fix(storage): updateConnection logs a failed restore instead of swallowing it (#1778) - #1791
Merged
Merged
Conversation
…nd secrets instead of swallowing it (#1778)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1778.
Contract (the first option from the issue): the restore stays best effort and the original error is still the one rethrown, but a failed restore is no longer silent. The row restore and the secrets restore are separate steps now, each logged with the connection id via
logIgnored, so a state of 'old row, new password' can be explained from the log. Test: a refused restore after a refused write reports the first error and logs the second. Not run locally, CI will.The other option (secrets first, row after) only moves the possible inconsistency to the other side, so it is not done here.